-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][test] Disable OpenTelemetrySanityTest #22996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the flaky group implemented for integration tests? I don't think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flaky group isn't implemented for integration tests. You'd have to remove the test from tests/integration/src/test/resources/pulsar-metrics.xml to disable it.
It seems that this can also be avoided, although the CI is running, but in fact the test is not executed. https://github.com/Technoboy-/pulsar/actions/runs/9777801504/job/26994205308?pr=52 |
do you mean that the flaky group can be used for ignoring an integration test? |
Yes, But this is not a good idea, and #22996 (review) is better |
Updated |
Ah, thanks for helping this, I try adding this in my local, and then run the test, but failed. it's a different error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Technoboy- Let wait for @dragosvictor to push a separate specifically PR from #22987 to fix the failing tests
Fix with by #22998 |
Motivation
OpenTelemetrySanityTest fails for every patch and blocks merging some important fixes.
It takes some time to fix it, so disable it .
We will track this issue by #22995.
Documentation
doc
doc-required
doc-not-needed
doc-complete