Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Disable OpenTelemetrySanityTest #22996

Closed
wants to merge 2 commits into from

Conversation

Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Jul 3, 2024

Motivation

OpenTelemetrySanityTest fails for every patch and blocks merging some important fixes.
It takes some time to fix it, so disable it .

We will track this issue by #22995.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- self-assigned this Jul 3, 2024
@Technoboy- Technoboy- added this to the 3.4.0 milestone Jul 3, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 3, 2024
@Technoboy- Technoboy- requested a review from shibd July 3, 2024 12:57
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the flaky group implemented for integration tests? I don't think so.

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flaky group isn't implemented for integration tests. You'd have to remove the test from tests/integration/src/test/resources/pulsar-metrics.xml to disable it.

@shibd
Copy link
Member

shibd commented Jul 3, 2024

flaky group isn't implemented for integration tests. You'd have to remove the test from tests/integration/src/test/resources/pulsar-metrics.xml to disable it.

It seems that this can also be avoided, although the CI is running, but in fact the test is not executed.

https://github.com/Technoboy-/pulsar/actions/runs/9777801504/job/26994205308?pr=52

@lhotari
Copy link
Member

lhotari commented Jul 3, 2024

flaky group isn't implemented for integration tests. You'd have to remove the test from tests/integration/src/test/resources/pulsar-metrics.xml to disable it.

It seems that this can also be avoided, although the CI is running, but in fact the test is not executed.

https://github.com/Technoboy-/pulsar/actions/runs/9777801504/job/26994205308?pr=52

do you mean that the flaky group can be used for ignoring an integration test?

@shibd
Copy link
Member

shibd commented Jul 3, 2024

do you mean that the flaky group can be used for ignoring an integration test?

Yes, But this is not a good idea, and #22996 (review) is better

@Technoboy-
Copy link
Contributor Author

do you mean that the flaky group can be used for ignoring an integration test?

Yes, But this is not a good idea, and #22996 (review) is better

Updated

@Technoboy- Technoboy- changed the title [fix][test] Move OpenTelemetrySanityTest to flaky group [fix][test] Disable OpenTelemetrySanityTest Jul 3, 2024
@dragosvictor
Copy link
Contributor

Test failure is addressed by 5a2e304. Upstream docker image had a breaking change in v0.104.0, where the listener binds to localhost unless otherwise instructed (ref).

@Technoboy-
Copy link
Contributor Author

Technoboy- commented Jul 3, 2024

Test failure is addressed by 5a2e304. Upstream docker image had a breaking change in v0.104.0, where the listener binds to localhost unless otherwise instructed (ref).

Test failure is addressed by 5a2e304. Upstream docker image had a breaking change in v0.104.0, where the listener binds to localhost unless otherwise instructed (ref).

Ah, thanks for helping this, I try adding this in my local, and then run the test, but failed. it's a different error.

Copy link
Member

@shibd shibd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Technoboy- Let wait for @dragosvictor to push a separate specifically PR from #22987 to fix the failing tests

@shibd
Copy link
Member

shibd commented Jul 3, 2024

Fix with by #22998

@shibd shibd closed this Jul 3, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants