-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[branch-2.1] pick some prs #39860
Merged
Merged
[branch-2.1] pick some prs #39860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
…hange some Errors stacktrace (apache#38978) Issue Number: close #xxx 1. introduce `ERROR_CTOR_NOSTACK` to make some Doris' native error don't print stacktrace by default. 2. when streamload exceed limit, just tell user which conf to change
…nts (apache#39255) ## Proposed changes Issue Number: close #xxx before: crash or ```sql mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random; +---------------------------------------------------------+ | random(1, array_size(split_by_string(`fcst_emp`, ','))) | +---------------------------------------------------------+ | 7471044383762196303 | +---------------------------------------------------------+ 1 row in set (0.05 sec) ``` now: both for nereids and legacy planner: ```sql mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.8)[INVALID_ARGUMENT]The param of rand function must be literal ``` doc pr: apache/doris-website#992
…RR (apache#39324) Issue Number: close #xxx before: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | NULL | +---------------------------------------+ 1 row in set (0.53 sec) ``` --- actually here's a silent nan by float exception. now sure in all platform. after: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | 0 | +---------------------------------------+ 1 row in set (0.13 sec) ``` --- is stable
… which relative column is not null (apache#39449) Issue Number: close #xxx before: ```sql CREATE TABLE `test_null` ( `k0` BIGINT NOT NULL, `k1` BIGINT NOT NULL ) partition by list (k0, k1) ( PARTITION `pX` values in ((NULL, 1)) ) PROPERTIES ( "replication_allocation" = "tag.location.default: 1" ); ``` may core in local exchange for inserting. now: ```sql mysql [test]>CREATE TABLE `test_null` ( -> `k0` BIGINT NOT NULL, -> `k1` BIGINT NOT NULL -> ) -> partition by list (k0, k1) ( -> PARTITION `pX` values in ((NULL, 1)) -> ) -> PROPERTIES ( -> "replication_allocation" = "tag.location.default: 1" -> ); ERROR 1105 (HY000): errCode = 2, detailMessage = errCode = 2, detailMessage = Can't have null partition is for NOT NULL partition column in partition expr's index 0 ```
apache#39695) Issue Number: close #xxx Before, if `dynamic_partition_check_interval_seconds` is 86400 now and we want to set it to 1, the set operation will not go into effect in 86400 seconds in worst situation. Now all set operation will norify scheduler thread and set the interval immediately. Now only applied for `DynamicPartitionScheduler`. should check other daemons in future.
…he#39754) Add some partition expr check on creating table
run buildall |
run buildall |
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
#38385 optimize parsing datetime
#38978 make stream load failure message more clear and disable some error's stacktrace by default
#39255 fix random function coredump
#39324 fix function corr inconsistency with doc
#39449 check auto partitoin nullity when creating partition
#39695 make DynamicPartitionScheduler immediately know interval's change
#39754 Add some partition expr check on creating table