Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.1] pick some prs #39860

Merged
merged 9 commits into from
Aug 24, 2024
Merged

[branch-2.1] pick some prs #39860

merged 9 commits into from
Aug 24, 2024

Conversation

zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Aug 23, 2024

Proposed changes

Issue Number: close #xxx

#38385 optimize parsing datetime
#38978 make stream load failure message more clear and disable some error's stacktrace by default
#39255 fix random function coredump
#39324 fix function corr inconsistency with doc
#39449 check auto partitoin nullity when creating partition
#39695 make DynamicPartitionScheduler immediately know interval's change
#39754 Add some partition expr check on creating table

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/runtime/vdatetime_value.cpp Show resolved Hide resolved
be/src/vec/runtime/vdatetime_value.cpp Show resolved Hide resolved
…hange some Errors stacktrace (apache#38978)

Issue Number: close #xxx

1. introduce `ERROR_CTOR_NOSTACK` to make some Doris' native error don't
print stacktrace by default.
2. when streamload exceed limit, just tell user which conf to change
…nts (apache#39255)

## Proposed changes

Issue Number: close #xxx

before:
crash or
```sql
mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random;
+---------------------------------------------------------+
| random(1, array_size(split_by_string(`fcst_emp`, ','))) |
+---------------------------------------------------------+
|                                     7471044383762196303 |
+---------------------------------------------------------+
1 row in set (0.05 sec)
```

now:
both for nereids and legacy planner:
```sql
mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random;
ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.8)[INVALID_ARGUMENT]The param of rand function must be literal
```

doc pr: apache/doris-website#992
…RR (apache#39324)

Issue Number: close #xxx

before:
```sql
mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE;
+---------------------------------------+
| corr(data, cast(89.999999 as DOUBLE)) |
+---------------------------------------+
|                                  NULL |
+---------------------------------------+
1 row in set (0.53 sec)
```
--- actually here's a silent nan by float exception. now sure in all
platform.

after:
```sql
mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE;
+---------------------------------------+
| corr(data, cast(89.999999 as DOUBLE)) |
+---------------------------------------+
|                                     0 |
+---------------------------------------+
1 row in set (0.13 sec)
```
--- is stable
… which relative column is not null (apache#39449)

Issue Number: close #xxx

before:
```sql
CREATE TABLE `test_null` (
`k0` BIGINT NOT NULL,
`k1` BIGINT NOT NULL
)
partition by list (k0, k1) (
PARTITION `pX` values in ((NULL, 1))
)
PROPERTIES (
"replication_allocation" = "tag.location.default: 1"
);
```
may core in local exchange for inserting.

now:
```sql
mysql [test]>CREATE TABLE `test_null` (
    -> `k0` BIGINT NOT NULL,
    -> `k1` BIGINT NOT NULL
    -> )
    -> partition by list (k0, k1) (
    -> PARTITION `pX` values in ((NULL, 1))
    -> )
    -> PROPERTIES (
    -> "replication_allocation" = "tag.location.default: 1"
    -> );
ERROR 1105 (HY000): errCode = 2, detailMessage = errCode = 2, detailMessage = Can't have null partition is for NOT NULL partition column in partition expr's index 0
```
apache#39695)

Issue Number: close #xxx

Before, if `dynamic_partition_check_interval_seconds` is 86400 now and
we want to set it to 1, the set operation will not go into effect in
86400 seconds in worst situation.
Now all set operation will norify scheduler thread and set the interval
immediately.

Now only applied for `DynamicPartitionScheduler`. should check other
daemons in future.
@zclllyybb
Copy link
Contributor Author

run buildall

@zclllyybb
Copy link
Contributor Author

run buildall

@zclllyybb
Copy link
Contributor Author

run buildall

@yiguolei yiguolei merged commit 460605a into apache:branch-2.1 Aug 24, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants