-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](function) fix coredump because short of check on randoms arguments #39255
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test only guarantee exception is thrown from FE. Modification on BE is not covered, and this is important, since we need to upgrade cluster.
When the pr is picked to 2.1, should add more tests to cover non-nereids planner.
实际上,最后面加的那个testcase,就是接收的从BE报的错: mysql [test]>set enable_nereids_planner=false;
Query OK, 0 rows affected (0.02 sec)
mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random;
ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.8)[INVALID_ARGUMENT]The param of rand function must be literal 剩下的交给升降级测试,回归里只能测到这些了(BE的报错本来就是兜底的,且老优化器的问题主要修复方式是不走老优化器) |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
master 上还有老优化器么我记得不是删了么已经 |
TPC-H: Total hot run time: 39449 ms
|
TPC-DS: Total hot run time: 202994 ms
|
ClickBench: Total hot run time: 31.06 s
|
还有,不清楚哪个版本删,而且我记得目前还不能直接删来着,有些语句新优化器都没支持上。。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
PR approved by at least one committer and no changes requested. |
…nts (apache#39255) ## Proposed changes Issue Number: close #xxx before: crash or ```sql mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random; +---------------------------------------------------------+ | random(1, array_size(split_by_string(`fcst_emp`, ','))) | +---------------------------------------------------------+ | 7471044383762196303 | +---------------------------------------------------------+ 1 row in set (0.05 sec) ``` now: both for nereids and legacy planner: ```sql mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.8)[INVALID_ARGUMENT]The param of rand function must be literal ``` doc pr: apache/doris-website#992
…nts (#39255) ## Proposed changes Issue Number: close #xxx before: crash or ```sql mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random; +---------------------------------------------------------+ | random(1, array_size(split_by_string(`fcst_emp`, ','))) | +---------------------------------------------------------+ | 7471044383762196303 | +---------------------------------------------------------+ 1 row in set (0.05 sec) ``` now: both for nereids and legacy planner: ```sql mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.8)[INVALID_ARGUMENT]The param of rand function must be literal ``` doc pr: apache/doris-website#992
…nts (apache#39255) ## Proposed changes Issue Number: close #xxx before: crash or ```sql mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random; +---------------------------------------------------------+ | random(1, array_size(split_by_string(`fcst_emp`, ','))) | +---------------------------------------------------------+ | 7471044383762196303 | +---------------------------------------------------------+ 1 row in set (0.05 sec) ``` now: both for nereids and legacy planner: ```sql mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.8)[INVALID_ARGUMENT]The param of rand function must be literal ``` doc pr: apache/doris-website#992
…nts (apache#39255) ## Proposed changes Issue Number: close #xxx before: crash or ```sql mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random; +---------------------------------------------------------+ | random(1, array_size(split_by_string(`fcst_emp`, ','))) | +---------------------------------------------------------+ | 7471044383762196303 | +---------------------------------------------------------+ 1 row in set (0.05 sec) ``` now: both for nereids and legacy planner: ```sql mysql [test]>select random(1,array_size(split_by_string(fcst_emp,','))) from test_random; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.8)[INVALID_ARGUMENT]The param of rand function must be literal ``` doc pr: apache/doris-website#992
## Proposed changes Issue Number: close #xxx #38385 optimize parsing datetime #38978 make stream load failure message more clear and disable some error's stacktrace by default #39255 fix random function coredump #39324 fix function corr inconsistency with doc #39449 check auto partitoin nullity when creating partition #39695 make DynamicPartitionScheduler immediately know interval's change #39754 Add some partition expr check on creating table
Proposed changes
Issue Number: close #xxx
before:
crash or
now:
both for nereids and legacy planner:
doc pr: apache/doris-website#992