[Enhancement](partition) Forbid create table with null partition item which relative column is not null #39449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zclllyybb
force-pushed
the
check_partition_null
branch
from
1fcbbec
to
0ea204f
Compare
|
run buildall |
zclllyybb
force-pushed
the
check_partition_null
branch
from
0ea204f
to
58cb1b3
Compare
|
run buildall |
TPC-H: Total hot run time: 38355 ms |
TPC-DS: Total hot run time: 190112 ms |
ClickBench: Total hot run time: 31.82 s |
zclllyybb
force-pushed
the
check_partition_null
branch
from
58cb1b3
to
b62e7ab
Compare
zclllyybb
force-pushed
the
check_partition_null
branch
from
b62e7ab
to
4fcb1f5
Compare
|
run buildall |
TPC-H: Total hot run time: 38502 ms |
TPC-DS: Total hot run time: 190879 ms |
ClickBench: Total hot run time: 31.01 s |
|
run buildall |
TPC-H: Total hot run time: 37878 ms |
TPC-DS: Total hot run time: 196944 ms |
ClickBench: Total hot run time: 31.06 s |
zclllyybb
force-pushed
the
check_partition_null
branch
from
a121d6d
to
8f2b82b
Compare
|
run buildall |
TPC-H: Total hot run time: 37985 ms |
TPC-DS: Total hot run time: 195999 ms |
ClickBench: Total hot run time: 31.26 s |
zhangstar333
approved these changes
Aug 19, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
BiteTheDDDDt
approved these changes
Aug 19, 2024
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Aug 23, 2024
… which relative column is not null (apache#39449) Issue Number: close #xxx before: ```sql CREATE TABLE `test_null` ( `k0` BIGINT NOT NULL, `k1` BIGINT NOT NULL ) partition by list (k0, k1) ( PARTITION `pX` values in ((NULL, 1)) ) PROPERTIES ( "replication_allocation" = "tag.location.default: 1" ); ``` may core in local exchange for inserting. now: ```sql mysql [test]>CREATE TABLE `test_null` ( -> `k0` BIGINT NOT NULL, -> `k1` BIGINT NOT NULL -> ) -> partition by list (k0, k1) ( -> PARTITION `pX` values in ((NULL, 1)) -> ) -> PROPERTIES ( -> "replication_allocation" = "tag.location.default: 1" -> ); ERROR 1105 (HY000): errCode = 2, detailMessage = errCode = 2, detailMessage = Can't have null partition is for NOT NULL partition column in partition expr's index 0 ```
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Aug 23, 2024
… which relative column is not null (apache#39449) Issue Number: close #xxx before: ```sql CREATE TABLE `test_null` ( `k0` BIGINT NOT NULL, `k1` BIGINT NOT NULL ) partition by list (k0, k1) ( PARTITION `pX` values in ((NULL, 1)) ) PROPERTIES ( "replication_allocation" = "tag.location.default: 1" ); ``` may core in local exchange for inserting. now: ```sql mysql [test]>CREATE TABLE `test_null` ( -> `k0` BIGINT NOT NULL, -> `k1` BIGINT NOT NULL -> ) -> partition by list (k0, k1) ( -> PARTITION `pX` values in ((NULL, 1)) -> ) -> PROPERTIES ( -> "replication_allocation" = "tag.location.default: 1" -> ); ERROR 1105 (HY000): errCode = 2, detailMessage = errCode = 2, detailMessage = Can't have null partition is for NOT NULL partition column in partition expr's index 0 ```
yiguolei
pushed a commit
that referenced
this pull request
Aug 24, 2024
## Proposed changes Issue Number: close #xxx #38385 optimize parsing datetime #38978 make stream load failure message more clear and disable some error's stacktrace by default #39255 fix random function coredump #39324 fix function corr inconsistency with doc #39449 check auto partitoin nullity when creating partition #39695 make DynamicPartitionScheduler immediately know interval's change #39754 Add some partition expr check on creating table
dataroaring
pushed a commit
that referenced
this pull request
Aug 26, 2024
… which relative column is not null (#39449) ## Proposed changes Issue Number: close #xxx before: ```sql CREATE TABLE `test_null` ( `k0` BIGINT NOT NULL, `k1` BIGINT NOT NULL ) partition by list (k0, k1) ( PARTITION `pX` values in ((NULL, 1)) ) PROPERTIES ( "replication_allocation" = "tag.location.default: 1" ); ``` may core in local exchange for inserting. now: ```sql mysql [test]>CREATE TABLE `test_null` ( -> `k0` BIGINT NOT NULL, -> `k1` BIGINT NOT NULL -> ) -> partition by list (k0, k1) ( -> PARTITION `pX` values in ((NULL, 1)) -> ) -> PROPERTIES ( -> "replication_allocation" = "tag.location.default: 1" -> ); ERROR 1105 (HY000): errCode = 2, detailMessage = errCode = 2, detailMessage = Can't have null partition is for NOT NULL partition column in partition expr's index 0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
before:
may core in local exchange for inserting.
now: