[fix](function) avoid calculating sqrt of negative in agg function CORR #39324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zclllyybb
changed the title
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39845 ms |
TPC-DS: Total hot run time: 185304 ms |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39712 ms |
TPC-DS: Total hot run time: 184825 ms |
ClickBench: Total hot run time: 30.98 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40249 ms |
TPC-DS: Total hot run time: 185835 ms |
ClickBench: Total hot run time: 30.51 s |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 37311 ms |
TPC-DS: Total hot run time: 189731 ms |
ClickBench: Total hot run time: 31.32 s |
Mryange
approved these changes
Aug 15, 2024
BiteTheDDDDt
approved these changes
Aug 15, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Aug 17, 2024
…RR (#39324) ## Proposed changes Issue Number: close #xxx before: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | NULL | +---------------------------------------+ 1 row in set (0.53 sec) ``` --- actually here's a silent nan by float exception. now sure in all platform. after: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | 0 | +---------------------------------------+ 1 row in set (0.13 sec) ``` --- is stable
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Aug 23, 2024
…RR (apache#39324) Issue Number: close #xxx before: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | NULL | +---------------------------------------+ 1 row in set (0.53 sec) ``` --- actually here's a silent nan by float exception. now sure in all platform. after: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | 0 | +---------------------------------------+ 1 row in set (0.13 sec) ``` --- is stable
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Aug 23, 2024
…RR (apache#39324) Issue Number: close #xxx before: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | NULL | +---------------------------------------+ 1 row in set (0.53 sec) ``` --- actually here's a silent nan by float exception. now sure in all platform. after: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | 0 | +---------------------------------------+ 1 row in set (0.13 sec) ``` --- is stable
yiguolei
pushed a commit
that referenced
this pull request
Aug 24, 2024
## Proposed changes Issue Number: close #xxx #38385 optimize parsing datetime #38978 make stream load failure message more clear and disable some error's stacktrace by default #39255 fix random function coredump #39324 fix function corr inconsistency with doc #39449 check auto partitoin nullity when creating partition #39695 make DynamicPartitionScheduler immediately know interval's change #39754 Add some partition expr check on creating table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
before:
--- actually here's a silent nan by float exception. now sure in all platform.
after:
--- is stable