-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](function) avoid calculating sqrt of negative in agg function CORR #39324
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39845 ms
|
TPC-DS: Total hot run time: 185304 ms
|
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39712 ms
|
TPC-DS: Total hot run time: 184825 ms
|
ClickBench: Total hot run time: 30.98 s
|
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40249 ms
|
TPC-DS: Total hot run time: 185835 ms
|
ClickBench: Total hot run time: 30.51 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run buildall |
TPC-H: Total hot run time: 37311 ms
|
TPC-DS: Total hot run time: 189731 ms
|
ClickBench: Total hot run time: 31.32 s
|
PR approved by at least one committer and no changes requested. |
…RR (#39324) ## Proposed changes Issue Number: close #xxx before: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | NULL | +---------------------------------------+ 1 row in set (0.53 sec) ``` --- actually here's a silent nan by float exception. now sure in all platform. after: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | 0 | +---------------------------------------+ 1 row in set (0.13 sec) ``` --- is stable
…RR (apache#39324) Issue Number: close #xxx before: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | NULL | +---------------------------------------+ 1 row in set (0.53 sec) ``` --- actually here's a silent nan by float exception. now sure in all platform. after: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | 0 | +---------------------------------------+ 1 row in set (0.13 sec) ``` --- is stable
…RR (apache#39324) Issue Number: close #xxx before: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | NULL | +---------------------------------------+ 1 row in set (0.53 sec) ``` --- actually here's a silent nan by float exception. now sure in all platform. after: ```sql mysql [sqlfunctest]>SELECT CORR(data, 89.999999) FROM DOUBLEDATA_NOT_EMPTY_NULLABLE; +---------------------------------------+ | corr(data, cast(89.999999 as DOUBLE)) | +---------------------------------------+ | 0 | +---------------------------------------+ 1 row in set (0.13 sec) ``` --- is stable
## Proposed changes Issue Number: close #xxx #38385 optimize parsing datetime #38978 make stream load failure message more clear and disable some error's stacktrace by default #39255 fix random function coredump #39324 fix function corr inconsistency with doc #39449 check auto partitoin nullity when creating partition #39695 make DynamicPartitionScheduler immediately know interval's change #39754 Add some partition expr check on creating table
Proposed changes
Issue Number: close #xxx
before:
--- actually here's a silent nan by float exception. now sure in all platform.
after:
--- is stable