-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirmation dialog when accepting / rejecting / delete request #826
Conversation
Added alert for accept , reject and delete requests.
Added alert dialogue to feedback section
@Hyper-Matrix please squash your commits as mentioned in contributing guidelines |
@rpattath I am really confused about how to squash a PR. Can you please help me out with the same? |
Take a look at this https://stackoverflow.com/questions/14534397/squash-all-my-commits-into-one-for-github-pull-request. Let me know if it helps. |
Yes @rpattath it does help. But the issue is neither my android studio terminal nor my cmd(for git bash) works. Whenever I try to open them it crashes. So I use github desktop. So is there anyway I can implement this using github desktop ? |
Awesome work @Hyper-Matrix ! Could you attach screenshots of the dialogue shown when accepting and rejecting the request. |
@rpattath Thanks.......I have attached it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Hyper-Matrix which branch have you created this PR from ? It is showing unknown repo. |
@rpattath Even I can't understand whats the issue. I have the repo in my github. What should I do now? A new PR? |
@rpattath Can't it be merged if it remains unknown? |
@Hyper-Matrix hello , after creating this PR did you delete your fork and then re-forked it again? |
@vj-codes Yeah, I actually realized that...So I asked...I think it can be merged so do I need to put up another PR? |
@Hyper-Matrix before merging all PRs are tested by QA team , but since this PR does not have any specific repo and branch , testing will not be possible/not successful. |
@vj-codes Is there any other way out? Else I will submit a new PR. |
@anna4j what do you suggest ? ^^^ |
@Hyper-Matrix please submit a new PR. Make sure you use create it from a local branch under your fork and not from develop branch. |
@rpattath just to make sure I had already submitted the doc for OSH. After this PR will it be fine to submit it again? |
Description
I have added the Alert dialogues for accepting, rejecting, and deleting requests.
Fixes #250
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
Tested on my device (Redmi Note 5 pro).
Screenshot -
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only