Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a confirmation dialog when accepting / rejecting / delete request #250

Closed
Rimjhim28 opened this issue Dec 1, 2019 · 10 comments · Fixed by #949
Closed

Create a confirmation dialog when accepting / rejecting / delete request #250

Rimjhim28 opened this issue Dec 1, 2019 · 10 comments · Fixed by #949
Assignees
@Hyper-Matrix
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.

Comments

@Rimjhim28
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As of now the mentorship requests can be accepted or rejected as soon as the accept or reject button is pressed.

Describe the solution you'd like
Create warning dialog boxes that appear when the buttons are pressed. For example, when the user first clicks on the "Accept" button instead of directly accepting the request a dialog box should appear. The user will now have the choice to either accept the request or dismiss the dialog box.
@bartekpacia
Copy link
Contributor

I'm willing to work on implementing this.

@bartekpacia bartekpacia mentioned this issue Dec 3, 2019
Closed
11 tasks
@asawesome07 asawesome07 mentioned this issue Dec 4, 2019
Closed
11 tasks
@asawesome07
Copy link
Contributor

i am willing to work on implementing this

@asawesome07 asawesome07 mentioned this issue Dec 4, 2019
Closed
11 tasks
@daksha-aeer
Copy link
Contributor

Working on it!

daksha-aeer added a commit to daksha-aeer/mentorship-android that referenced this issue Dec 5, 2019
@daksha-aeer
feat: Create warning dialog boxes to accept and reject mentorship req…
923d352 
…uests

AlertDialog builder used in setOnClickListeners() function for accept and reject buttons. This will resolve issue anitab-org#250
@daksha-aeer daksha-aeer mentioned this issue Dec 5, 2019
Closed
3 tasks
daksha-aeer added a commit to daksha-aeer/mentorship-android that referenced this issue Dec 6, 2019
@daksha-aeer
feat: Create warning dialog boxes to accept and reject mentorship req…
bde1ac9 
…uests

AlertDialog builder used in setOnClickListeners() function for accept and reject buttons. This will resolve issue anitab-org#250
@uehara1107
Copy link

I want to tackle this challenge.

@daksha-aeer daksha-aeer mentioned this issue Dec 7, 2019
Closed
3 tasks
@Hardik0403 Hardik0403 mentioned this issue Dec 15, 2019
Closed
11 tasks
@Hardik0403
Copy link
Contributor

I am working on it.

@daksha-aeer daksha-aeer mentioned this issue Dec 28, 2019
Closed
11 tasks
daksha-aeer added a commit to daksha-aeer/mentorship-android that referenced this issue Dec 28, 2019
@daksha-aeer
fix: Request Detail screen button and text overlap
242c71a 
ScrollView added

Fixes anitab-org#250
@daksha-aeer daksha-aeer mentioned this issue Dec 28, 2019
Closed
11 tasks
daksha-aeer added a commit to daksha-aeer/mentorship-android that referenced this issue Dec 28, 2019
@daksha-aeer
feat: Redesign member page
a3f0a25 
Work done:
- AvatarView and Picasso library imported in app.gradle to display avatar.
- DividerItemDecoration used to display dividers in RecyclerView items.
- Font sizes changed

Reference:
- Avatar View: https://github.com/TangoAgency/avatar-view
- DividerItemDecoration: https://stackoverflow.com/questions/24618829/how-to-add-dividers-and-spaces-between-items-in-recyclerview

Resolves issue anitab-org#250
@amosgamaliel amosgamaliel mentioned this issue Dec 30, 2019
Closed
7 tasks
@ilyamaier ilyamaier mentioned this issue Jan 2, 2020
Closed
3 tasks
@isabelcosta isabelcosta mentioned this issue Feb 23, 2020
Closed
4 tasks
@annabauza annabauza mentioned this issue Feb 24, 2020
Closed
11 tasks
@isabelcosta isabelcosta added Status: Available Issue was approved and available to claim or abandoned for over 3 days. Category: Coding Changes to code base or refactored code that doesn't fix a bug. labels May 3, 2020
@isabelcosta
Copy link
Member

I just want to mention that PR #600 has useful reviews that can help next contributor to work on this :)

@vj-codes vj-codes added Status: Possible Future Feature This needs to be discussed at a future time. Type: Enhancement New feature or request. labels May 21, 2020
@vj-codes vj-codes mentioned this issue May 21, 2020
Closed
@vj-codes vj-codes mentioned this issue Aug 23, 2020
Closed
3 tasks
@rpattath rpattath added Open Source Hack and removed Status: Possible Future Feature This needs to be discussed at a future time. labels Aug 23, 2020
@isabelcosta isabelcosta changed the title Create a confirmation dialog when accepting or rejecting mentorship request Create a confirmation dialog when accepting / rejecting / delete request Aug 25, 2020
@rpattath rpattath mentioned this issue Aug 25, 2020
Closed
@Hyper-Matrix
Copy link
Contributor

Can I be assigned this issue for OSH?

@aditmehta9
Copy link
Member

Can I be assigned this issue for OSH?

Yes of course. OSH starts on 1st September and I can't officially assign you just yet. Your PR will be considered for OSH only if you're assigned after 1st. Before that, if I assign you it'll be a regular contribution and please tag project managers to claim issue.

@Hyper-Matrix
Copy link
Contributor

I would like to work on this issue as a part of OSH. Can you assign me this issue?

@aditmehta9
Copy link
Member

Yes

@aditmehta9 aditmehta9 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Aug 31, 2020
This was referenced Sep 1, 2020
Closed
Closed
@Hyper-Matrix Hyper-Matrix mentioned this issue Sep 21, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hyper-Matrix Hyper-Matrix

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.
Projects
None yet
Milestone
No milestone