Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI design for profiles page added #830

Closed
wants to merge 7 commits into from
Closed

New UI design for profiles page added #830

wants to merge 7 commits into from

Conversation

Hyper-Matrix
Copy link
Contributor

@Hyper-Matrix Hyper-Matrix commented Sep 2, 2020

Description

The new UI for My Profile screen has been added (mockup)
Fixes #807

Type of Change:

  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

GIF-
ezgif com-video-to-gif (1)

ScreenShot-
profile

Checklist:

  • My PR follows the style guidelines of this project

Code/Quality Assurance Only

  • My changes generate no new warnings

Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hyper-Matrix you were supposed to submit In one of png / jpeg / Figma URL / ai formats. In the PR add an image of the design to /docs/ui folder. and not code the design

@Hyper-Matrix
Copy link
Contributor Author

Hyper-Matrix commented Sep 2, 2020

@vj-codes I have added the jpeg files in the docs/UI folder. I haven't codded anything, the code is for issues #824 #826. So I created a branch UI and added it. If you can see I have created a folder doc and UI and added the image. If am wrong anywhere please guide me out.

@iofall
Copy link

iofall commented Sep 2, 2020

@Hyper-Matrix you need to separate your commits across issues. This issue is only for redesign so it should only contain commits for redesign and not any other issue. Please remove the other commits and only keep those that are relevant for this issue.

Copy link

@iofall iofall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each issue, you should create a separate branch which helps in separation of commits across issues.

@iofall iofall added the Status: Changes Requested Changes are required to be done by the PR author. label Sep 2, 2020
@iofall
Copy link

iofall commented Sep 2, 2020

Also @Hyper-Matrix please remember to follow the Contributing Guidelines your commit messages are not according to the guidelines.

@Hyper-Matrix
Copy link
Contributor Author

I closing this PR and submitting a new one.

@vj-codes vj-codes added Category: User Interface Improvements or additions to design. Open Source Hack and removed Status: Changes Requested Changes are required to be done by the PR author. labels Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: User Interface Improvements or additions to design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign: My Profile / Edit Profile screen
4 participants