Update to use Googletest v1.10.0 (latest) #8

audrow · 2020-10-01T16:41:43Z

I merged in the latest tag of googletest and updated the version number in the package.xml.

The following PRs are required for this PR:

…llout PiperOrigin-RevId: 245430295

Internal Change PiperOrigin-RevId: 245788057

PiperOrigin-RevId: 245798478

Clarify build system support - CMake and automake community supported PiperOrigin-RevId: 245821927

PiperOrigin-RevId: 246550729

Remove special case for protocol buffers. It is no longer needed. PiperOrigin-RevId: 246550795

Print the test output on assertion failure. PiperOrigin-RevId: 247283764

Otherwise the code won't compile if the '&' operater is overloaded and return something that cannot be casted to void *.

PiperOrigin-RevId: 248759825

Adding back section that was lost in merge

Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>

windows msvc toolchain with werror and wconversion will break if converting long to DWORD.

Cleanup, remove legacy build scripts, googletest only provides Bazel and CMake

PiperOrigin-RevId: 249500162

PiperOrigin-RevId: 249660276

Clarify googler PR policy

As suggested in google#2150.

Add a safety nullptr check to catch the case where the /tmp file used for capturing a stream cannot be created. PiperOrigin-RevId: 250523012

PiperOrigin-RevId: 250620088

Previously this was fused into the source file, but this prevents users of the fused file from using those utilities directly.

audrow · 2020-10-01T22:45:46Z

I opened a few PRs to fix the warnings:

audrow · 2020-10-01T22:48:49Z

Here is a new CI attempt:

Linux

audrow · 2020-10-02T03:45:15Z

Here is the full CI:

Build: --packages-above-and-dependencies gtest_vendor gmock_vendor
Test: --packages-above gtest_vendor gmock_vendor

Linux (From above, not rerun)
Linux-aarch64
macOS (rerun)
Windows

clalancette

This change (plus the fixes in the downstream packages) seem good to me. But I'd like to get an opinion from @wjwwood before we merge.

googletest/package.xml

audrow · 2020-10-06T19:49:42Z

I think that I did something wrong in updating from googletest and it was hard to tell because the merged in commits were squashed. Now, this PR updates our ros2 branch to googletest's latest release (1.10.0).

I've chosen not to squash the commits, since it is what we seem to have done in the past, it makes things clearer, and it should make future updates easier.

One other note that might be useful in the future: instead of rebasing, I've chosen to merge these commits when updating from googletest. Rebasing would modify this repository's history (would require a forced push) and make it hard to go back to previous versions.

I'll rerun CI.

audrow · 2020-10-06T20:20:58Z

Below is CI. Note that I use --pytest-args -m scoobydo in testing to avoid running python tests, because several python tests fail on Windows and these python tests should be unrelated to googletest.

Build: --packages-above-and-dependencies gtest_vendor gmock_vendor
Test: --pytest-args -m scoobydo --packages-above gtest_vendor gmock_vendor

Linux
Linux-aarch64
macOS
Windows

audrow · 2020-10-06T22:08:32Z

~~Using the last release of googletest didn't fix the warnings that we have seen (e.g., ros2/urdfdom#22 (comment)), so I am going to try using a more recent commit on master.~~

ros2/urdfdom#22 is failing on macOS because the wrong headers are being used (see ros2/urdfdom#23). A better example of 1.10.0 fixing warnings is in ros2/rcl_logging#54 (comment). Note that the most recent version of googletest that passed their CI had two warnings.

….10.0-2 Signed-off-by: Audrow Nash <audrow.nash@gmail.com>

Signed-off-by: Audrow Nash <audrow.nash@gmail.com>

audrow · 2020-10-16T05:16:11Z

Here's my latest run of Window's CI:

It has two test failures that I see in nightly_win_rep here.

I'll rerun all of the CI's tonight and if we only see these failures, perhaps we can merge this and the associated PRs in.

audrow · 2020-10-16T15:46:06Z

Here's the new CI. Again, I see the windows failures in the nightly_win_rep in the last few days.

Linux
Linux-aarch64
macOS
Windows

clalancette · 2020-10-16T19:09:30Z

Here's the new CI. Again, I see the windows failures in the nightly_win_rep in the last few days.

Yeah, I agree that those are flaky tests. So we can ignore those. The changes you have made in this repository also look good.

One thing I would like to see is a run of this on Windows Debug and on CentOS. Windows Debug, in particular, has caused a lot of problems in the past, so that would be a good one to see what happens. And while CentOS is not one of our Tier 1 platforms, we do generally try to keep it working, so let's see what happens there.

Finally, can you summarize the PRs that are required to get this in? I'd like to get that subset in first before we start enabling warnings elsewhere.

audrow · 2020-10-16T21:17:07Z

Here are two new CI runs:

Linux-CentOS
Windows (Debug)

audrow · 2020-10-16T21:19:34Z

The required PRs that should be merged in with this PR are

All of the recent CI runs have tested these PRs, too.

clalancette · 2020-10-19T15:06:28Z

The things that failed in Windows Debug and CentOS are the same that failed in the nightlies, so those are good. I'm happy with this PR, so I'll re-approve and then go look at the other 3 PRs.

clalancette · 2020-10-19T15:10:22Z

One other thing; once you merge this and the dependent PRs, please make sure to do a release of this package, rcl, rclcpp, and system_tests into Rolling. Otherwise all downstream PR jobs are going to start failing.

hidmic · 2020-10-20T17:56:27Z

Alright, everyone's happy with the patch, and so am I. Merging on @audrow 's behalf. Thanks!

SylvestreG and others added 30 commits April 26, 2019 13:48

Fix compilation on CentOS 7

9037e9b

Merge pull request google#2241 from ngie-eign:fix-wsign-conversion-fa…

61cdca5

…llout PiperOrigin-RevId: 245430295

Googletest export

82f9c8d

Internal Change PiperOrigin-RevId: 245788057

Removing obsolete codegear and msvc 2010

87348c2

Removing obsolete msvc 2005 and 2010

3c911d2

Merge pull request google#2242 from SylvestreG:master

9997a83

PiperOrigin-RevId: 245798478

Fix -Wsign-conversion error by adding static_cast

ca642a9

Googletest export

63be3dc

Clarify build system support - CMake and automake community supported PiperOrigin-RevId: 245821927

Merge pull request google#2245 from daquexian:fix_wsign_conversion

bf3ef5c

PiperOrigin-RevId: 246550729

Googletest export

3f5b5b8

Remove special case for protocol buffers. It is no longer needed. PiperOrigin-RevId: 246550795

Googletest export

5299815

Print the test output on assertion failure. PiperOrigin-RevId: 247283764

Use std::addressof to instead of plain '&'.

2fc2383

Otherwise the code won't compile if the '&' operater is overloaded and return something that cannot be casted to void *.

Added docs for testing::RegisterTest

9d4cde4

add unit test for overload & operator

5b4a135

Merge pull request google#2254 from chaoran:master

03273a8

PiperOrigin-RevId: 248759825

Update advanced.md

f71fb4f

Adding back section that was lost in merge

Fix typo introduced in 63be3dc (maintaners -> maintainers)

699943f

Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>

unbreak windows build

2f58f41

windows msvc toolchain with werror and wconversion will break if converting long to DWORD.

removing codegear

928f7a3

removing msvc

a67e9a8

removing msvc

feb55f2

Update README.md

dc792bc

Cleanup, remove legacy build scripts, googletest only provides Bazel and CMake

Merge pull request google#2259 from ngie-eign:fix-maintainers-typo

88f0493

PiperOrigin-RevId: 249500162

Merge pull request google#2260 from 741g:master

7f1c0f6

PiperOrigin-RevId: 249660276

Update CONTRIBUTING.md

a2059b4

Clarify googler PR policy

Update CONTRIBUTING.md

f5edb4f

Suppress CMake policy warning (CMP0048)

97d8c47

As suggested in google#2150.

Googletest export

899c082

Add a safety nullptr check to catch the case where the /tmp file used for capturing a stream cannot be created. PiperOrigin-RevId: 250523012

Merge pull request google#2264 from mbrobbel:suppress-cmp0048-warning

8ffb7e5

PiperOrigin-RevId: 250620088

Fuse gtest-spi.h into the resulting header.

6044c26

Previously this was fused into the source file, but this prevents users of the fused file from using those utilities directly.

clalancette approved these changes Oct 5, 2020

View reviewed changes

wjwwood reviewed Oct 5, 2020

View reviewed changes

googletest/package.xml Show resolved Hide resolved

wjwwood approved these changes Oct 5, 2020

View reviewed changes

audrow mentioned this pull request Oct 6, 2020

Enable basic warnings ros2/urdfdom#22

Closed

audrow changed the title ~~Update to use Googletest v1.10.0 (latest)~~ Update Googletest to latest commit that passes CI Oct 6, 2020

Merge remote-tracking branch 'google/v1.10.x' into audrow/update-to-1…

ef83476

….10.0-2 Signed-off-by: Audrow Nash <audrow.nash@gmail.com>

audrow mentioned this pull request Oct 8, 2020

[rcl_logging_spdlog] Add warnings ros2/rcl_logging#54

Merged

Update version to 1.10.9000 in package.xmls

730e5da

Signed-off-by: Audrow Nash <audrow.nash@gmail.com>

audrow changed the title ~~Update Googletest to latest commit that passes CI~~ Update to use Googletest v1.10.0 (latest) Oct 8, 2020

This was referenced Oct 13, 2020

[rcl_lifecycle] Add warnings ros2/rcl#830

Merged

[rcl_yaml_param_parser] Add warnings ros2/rcl#831

Merged

[rclcpp_action] Add warnings ros2/rclcpp#1405

Merged

[rclcpp_components] Add warnings ros2/rclcpp#1406

Closed

clalancette approved these changes Oct 19, 2020

View reviewed changes

hidmic merged commit 0a38dbc into ament:ros2 Oct 20, 2020

audrow deleted the audrow/update-to-1.10.0 branch October 20, 2020 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to use Googletest v1.10.0 (latest) #8

Update to use Googletest v1.10.0 (latest) #8

audrow commented Oct 1, 2020 •

edited

Loading

audrow commented Oct 1, 2020

audrow commented Oct 1, 2020

audrow commented Oct 2, 2020 •

edited

Loading

clalancette left a comment

audrow commented Oct 6, 2020 •

edited

Loading

audrow commented Oct 6, 2020

audrow commented Oct 6, 2020 •

edited

Loading

audrow commented Oct 16, 2020

audrow commented Oct 16, 2020

clalancette commented Oct 16, 2020

audrow commented Oct 16, 2020

audrow commented Oct 16, 2020 •

edited

Loading

clalancette commented Oct 19, 2020

clalancette commented Oct 19, 2020

hidmic commented Oct 20, 2020 •

edited

Loading

Update to use Googletest v1.10.0 (latest) #8

Update to use Googletest v1.10.0 (latest) #8

Conversation

audrow commented Oct 1, 2020 • edited Loading

audrow commented Oct 1, 2020

audrow commented Oct 1, 2020

audrow commented Oct 2, 2020 • edited Loading

clalancette left a comment

Choose a reason for hiding this comment

audrow commented Oct 6, 2020 • edited Loading

audrow commented Oct 6, 2020

audrow commented Oct 6, 2020 • edited Loading

audrow commented Oct 16, 2020

audrow commented Oct 16, 2020

clalancette commented Oct 16, 2020

audrow commented Oct 16, 2020

audrow commented Oct 16, 2020 • edited Loading

clalancette commented Oct 19, 2020

clalancette commented Oct 19, 2020

hidmic commented Oct 20, 2020 • edited Loading

audrow commented Oct 1, 2020 •

edited

Loading

audrow commented Oct 2, 2020 •

edited

Loading

audrow commented Oct 6, 2020 •

edited

Loading

audrow commented Oct 6, 2020 •

edited

Loading

audrow commented Oct 16, 2020 •

edited

Loading

hidmic commented Oct 20, 2020 •

edited

Loading