unbreak windows build #2260
Merged
unbreak windows build #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows msvc toolchain with werror and wconversion will break if converting long to DWORD.
|
@741g Thank you for this contribution. Could you also find the appropriate appveyor build with the werror and wconversion so we can make sure this stays fixed. |
|
@ngie-eign any comments? |
How do I find the particular build? It's possible our setup (that got broken) might not be part of the current set of build targets, or the configuration doesnt overlap. |
|
@gennadiycivil, @741g: LGTM! |
|
249462159 |
gennadiycivil
added a commit
that referenced
this pull request
May 23, 2019
PiperOrigin-RevId: 249660276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows msvc toolchain with werror and wconversion
will break if converting long to DWORD.