Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on CentOS 7 #2242

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Fix compilation on CentOS 7 #2242

merged 1 commit into from
Apr 29, 2019

Conversation

SylvestreG
Copy link
Contributor

Hi here is a fix to allow google test cmake to works on CentOS 7. On this cmake VERSION was not mendatory.

user > uname -a
Linux localhost.localdomain 3.10.0-957.10.1.el7.x86_64 #1 SMP Mon Mar 18 15:06:45 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
user > cmake -v
cmake version 2.8.12.2

Best Regards,

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@SylvestreG
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gennadiycivil
Copy link
Contributor

Thank your for this contribution. Could you please elaborate and provide more information on exactly the issue / problems this is trying to address.
What is the before/after effect this would create and how is this beneficial?

@SylvestreG
Copy link
Contributor Author

HI Gennadiy,

I was trying to build googletest on CentOS 7 using cmake. But It does not work, it produce an error.

An issue seems to be created : #1786 but If I am right it was not fixed on the sourcetree.

My PR fix this issue and allow people to use googletest on CentOS7.

Best Regards,

@gennadiycivil
Copy link
Contributor

Also related, #2124

@gennadiycivil gennadiycivil merged commit 9037e9b into google:master Apr 29, 2019
gennadiycivil added a commit that referenced this pull request Apr 29, 2019
PiperOrigin-RevId: 245798478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants