Enable basic warnings

[audrow]

No description provided.

[clalancette]

Actually, rather than doing this, I think we should fix this main up, since it is buggy.

That is, if it ever got called with no arguments, it would index past the end of argv below and crash.

My suggestion here is to add:

if (argc != 2) {
  fprintf(stderr, "Usage: %s <urdf>\n", argv[0]);
  return 1;
}

And also add a return 0; to the end of the function for completeness.

[clalancette]

Looks good with green CI.

[audrow]

• Linux
• Linux-aarch64
• macOS
• Windows

[audrow]

For the MacOS CI, it seems that including console_bridge/console.h, includes a file that uses variadic macros.

ros/console_bridge#64 seems to be the solution to this problem. It was merged-in in May before the console_bridge 1.0.1 tag, which I believe is the one the used in the current console_bridge_vendor (here). However, the error suggests that ros/console_bridge#64 hasn't been applied, as it is the same warning addressed in the PR (note the ##__VA_ARGS).

[  3%] Building CXX object urdf_parser/CMakeFiles/urdfdom_model.dir/src/pose.cpp.o
In file included from /Users/osrf/jenkins-agent/workspace/ci_osx/ws/src/ros2/urdfdom/urdf_parser/src/pose.cpp:42:
/usr/local/include/console_bridge/console.h:67:88: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Wgnu-zero-variadic-macro-arguments]
  console_bridge::log(__FILE__, __LINE__, console_bridge::CONSOLE_BRIDGE_LOG_ERROR, fmt, ##__VA_ARGS__)

[audrow]

Here is a rerun of CI on macOS with a newer version of googletest (v1.10.0) from this PR: ament/googletest#8.
* macOS

Actually, this is misleading because the issue with macOS in this case is that the wrong headers are being applied.

[audrow]

Testing urdfdom and packages above it:

• Linux
• Linux-aarch64
• macOS
• Windows

[clalancette]

@audrow So, I've now moved main ROS 2 development for this package over to https://github.com/ros/urdfdom. Could you please move this PR over to that repository and close this one out? Thanks.

[audrow]

I've moved this PR over to ros#148.