Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small visual regression in the inspector #9654

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Fix small visual regression in the inspector #9654

merged 1 commit into from
Sep 6, 2018

Conversation

youknowriad
Copy link
Contributor

closes #9616

Just a small regression introduced by #9572 when we removed the slot's wrapper.

Testing instructions

Repeat instructions from #9616

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Sep 6, 2018
@youknowriad youknowriad added this to the 3.8 milestone Sep 6, 2018
@youknowriad youknowriad self-assigned this Sep 6, 2018
@youknowriad youknowriad mentioned this pull request Sep 6, 2018
Closed
@youknowriad youknowriad requested a review from a team September 6, 2018 12:29
aduth
aduth approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not great that we rely on the presence of a useless div for styling to effect correctly, but for the purposes of a quick regression fix it's acceptable.

@youknowriad youknowriad merged commit 8780cf8 into master Sep 6, 2018
@youknowriad youknowriad deleted the fix/visual-regression-inspector branch September 6, 2018 12:55
@ZebulanStanphill
Copy link
Member

@aduth I agree. In my opinion, the editor UI should use as few non-semantic HTML elements as possible.

@gziolo
Copy link
Member

gziolo commented Sep 6, 2018

Let's iterate on it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

@afercia afercia Awaiting requested review from afercia

Assignees

@youknowriad youknowriad

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.

Color settings on paragraph has lost padding
4 participants
@youknowriad @ZebulanStanphill @gziolo @aduth