Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color settings on paragraph has lost padding #9616

Closed
karmatosed opened this issue Sep 4, 2018 · 5 comments · Fixed by #9654
Closed

Color settings on paragraph has lost padding #9616

karmatosed opened this issue Sep 4, 2018 · 5 comments · Fixed by #9654
Assignees
@youknowriad
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@karmatosed
Copy link
Member

Just noticing what maybe is a little regression:

2018-09-04 at 21 26
@karmatosed karmatosed changed the title Color settings on pargraph has lot padding Color settings on pargraph has lost padding Sep 4, 2018
@karmatosed karmatosed changed the title Color settings on pargraph has lost padding Color settings on paragraph has lost padding Sep 4, 2018
@ianbelanger79
Copy link
Contributor

Hey @karmatosed, what browser are you seeing this in? I don't see this issue on Chrome or Firefox, Windows 10 OS.

@karmatosed
Copy link
Member Author

This is in Chrome using latest version.

@karmatosed
Copy link
Member Author

Interestingly it seems to be applying a 'last' class to not the last one to get this:

2018-09-04 at 22 03

@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label Sep 5, 2018
@afercia afercia added the [Type] Regression Related to a regression in the latest release label Sep 6, 2018
@afercia
Copy link
Contributor

afercia commented Sep 6, 2018

Seems to me this happens because after recent changes the "Advanced" panel doesn't have a wrapper div any longer (the div with role=presentation added by the Slot). While a new div has been added hardcoding it around the first two panels, InspectorAdvancedControls doesn't have a wrapper div so the CSS selectors don't work as expected. /Cc @youknowriad

@youknowriad youknowriad self-assigned this Sep 6, 2018
@youknowriad youknowriad mentioned this issue Sep 6, 2018
Merged
@youknowriad
Copy link
Contributor

Right @afercia I opened #9654 to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix small visual regression in the inspector WordPress/gutenberg
4 participants
@karmatosed @youknowriad @afercia @ianbelanger79