-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insufficient color contrast for calendar selected date and Publish button #15278
Comments
Thanks. This appears to be the standard WordPress primary button styles across the board, not just Gutenberg. Here's the conversation on this in Core Trac. https://core.trac.wordpress.org/ticket/31459 I'd like to get Accessibility Team's input on this. @afercia @LukePettway Examples of this same button used elsewhere: |
Publish button (and all the primary blue buttons in WordPress): This technique is explicitly mentioned in https://www.w3.org/TR/WCAG20-TECHS/G18.html. However, it's a compromise and the best option would be to just darken the Selected date within the calendar |
The next color up in our color chart that passes contrast is That would also allow us to remove that text shadow, which would be nice. |
Alrighty, as mentioned in the triage slack chat, let's break out the primary button issue into a Core Trac issue and work on the calendar date highlight in Gutenberg. |
Note: currently that #307bad isn't available as a colour in Gutenberg's palette of blues: We might want to review how blues are being used in an attempt to scale down the number of different shades in use. |
Ideally, the WordPress palette and the Gutenberg palette should be unified, in an effort to get the best of both worlds. I don't see great value in keeping two separate sets of colors, especially in terms of maintenance and consistency. |
Agreed! I'd really love to see our palette unified and pared down a wee bit. |
Glad to hear there's consensus! That's definitely a job for designers. I'd expect from the design team to open a Trac ticket and lead the effort to unify the two palettes 🙂 |
Note for triage: only one part of this issue should be moved to core Trac. Please keep this issue open. |
Note 2: the Publish button was fixed in #15544. The Calendar selected date still needs improvements. |
As mentioned in #15432 (comment) here's the relevant core Trac tickets: The design of the focus outline on buttons/elements could be improved a11y-focus: Standardizing the handling of :focus and :hover So maybe there's no need to move the first part of this issue to Trac, as there are already tickets about it. |
Current status of this ticket:
As soon as that last item is done, it should be safe to close this issue, or have I missed anything? |
I haven't been able to trace exactly where it changes, but in looking at the current color contrast for the selected date, the color is now rendering as |
I think you're right, @joedolson. Here's a screenshot of the current state. I'll close it out. Thanks everyone! |
Insufficient color contrast for calendar selected date and Publish button
Issue description
The selected date within the calendar, and the "Publish" button, have
insufficient color contrast, below the minimum threshold of 4.5:1 for
text:
Sufficient color contrast is important for users who have low-vision or
are color-blind, because text with a low contrast ratio may be difficult
or impossible for such users to see.
Issue Code
Remediation Guidance
Darken the background color to achieve a minimum contrast of 4.5:1.
Recommended Code
Relevant standards
AA)
Note: This issue may be a duplicate with other existing accessibility-related bugs in this project. This issue comes from the Gutenberg accessibility audit, performed by Tenon and funded by WP Campus. This issue is GUT-19 in Tenon's report
The text was updated successfully, but these errors were encountered: