Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker: selected date missing focus styling #15929

Closed
sarahmonster opened this issue May 30, 2019 · 2 comments · Fixed by #21600
Closed

Datepicker: selected date missing focus styling #15929

sarahmonster opened this issue May 30, 2019 · 2 comments · Fixed by #21600
Assignees
Labels
[Feature] UI Components Impacts or related to the UI component system [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@sarahmonster
Copy link
Member

When tabbing through the datepicker, non-existent focus styling on the selected date makes it look as though focus has been lost:

2019-05-30 23 58 39

To reproduce:

  1. Write a new post.
  2. Open the sidebar and select the date to open calendar.
  3. Press "Tab" 7 times to select the currently-selected date.
  4. No focus indicator is shown around the current selection.

I'd recommend using a much louder focus style than the existing browser-default outline—probably matching the focus ring style used on other components.

@sarahmonster sarahmonster added [Type] Bug An existing feature does not function as intended Needs Accessibility Feedback Need input from accessibility [a11y] Keyboard & Focus [Feature] UI Components Impacts or related to the UI component system labels May 30, 2019
@afercia
Copy link
Contributor

afercia commented Jun 1, 2019

Thank you for opening a specific issue 🙂 I think this is already covered in #15278 though?

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed Needs Accessibility Feedback Need input from accessibility labels Jun 1, 2019
@sarahmonster
Copy link
Member Author

Looks like that issue is referring to the colour contrast of the white text against the blue background for the selected date.

The issue here is that the selected date doesn't have focus styling (or any change to the styling to indicate focus) when it acquires keyboard focus. As a result, a user tabbing through can easily lose their place.

#15962 should resolve the problem once merged.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
3 participants