Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus state has low contrast #15277

Closed
karlgroves opened this issue Apr 30, 2019 · 1 comment
Closed

Focus state has low contrast #15277

karlgroves opened this issue Apr 30, 2019 · 1 comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@karlgroves
Copy link

Focus state has low contrast

  • Severity: Medium
  • Affected Populations:
    • Low-Vision
    • Motor Impaired
    • Cognitively Impaired
  • Platform(s):
    • All / Universal
  • Components affected:
    • Block Panel

Issue description

Some of the controls in the Block panel have very low contrast in their
focussed state.

All interactive elements should have a visible and obvious focus
indicator, so that sighted keyboard users have a clear indication of
which element has focus. The visual presentation of user interface
component states must have a contrast ratio of at least 3:1 against
adjacent color(s).

Issue Code
    .components-button.is-default:focus:enabled {
        background: #fafafa;
        color: #23282d;
        border-color: #999;
        box-shadow: inset 0 -1px 0 #999, 0 0 0 2px #bfe7f3;
        ...
    }

Remediation Guidance

Darken the box-shadow color on focus.

Recommended Code
    .components-button.is-default:focus:enabled {
        background: #fafafa;
        color: #23282d;
        border-color: #999;
        box-shadow: 0 0 0 1px #00a0d2;
        ...
    }

Relevant standards

Note: This issue may be a duplicate with other existing accessibility-related bugs in this project. This issue comes from the Gutenberg accessibility audit, performed by Tenon and funded by WP Campus. This issue is GUT-31 in Tenon's report

@gziolo gziolo added the Needs Accessibility Feedback Need input from accessibility label Apr 30, 2019
@melchoyce
Copy link
Contributor

Same issue as #15278. Closing in favor of #15432.

@melchoyce melchoyce added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label May 5, 2019
@gziolo gziolo added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed Needs Accessibility Feedback Need input from accessibility labels May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

5 participants