Update 2_2_2022 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes the support for statistics module in sonic-mgmt docker image
Why I did it Add TSA/B/C dualtor support Signed-off-by: Longxiang Lyu lolv@microsoft.com How I did it For TSA, toggle all the mux to standby if the device type is dualtor and there are active mux ports. For TSC, add mux status output. How to verify it Run TSA/B/C on a dualtor setup
…ycables (#9125) * [y_cable] Support for initialization of new Daemon ycable to support ycables This PR also adds the commit in sonic-platform-daemons 94fa239 [y_cable] refactor y_cable to a seperate logic and new daemon from xcvrd (#219) Why I did it This PR separates the logic of Y-Cable from xcvrd. Before this change we were utilizing xcvrd daemon to control all aspects of Y-Cable right from initialization to processing requests from other entities like orch,linkmgr. Now we would have another daemon ycabled which will serve this purpose. Logically everything still remains the same from the perspective of other daemons. it also take care aspects like init/delete daemon from Y-Cable perspective. How I did it To serve the purpose we build a new wheel sonic_ycabled-1.0-py3-none-any.whl and install it inside pmon. We also initalize the daemon ycabled which serves our purpose for refactor inside pmon How to verify it Ran the changes with an image for dualtor tests on a 7050cx3 platform Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Why I did it Minigraph parser added a new field 'cluster' to device_metadata, and then yang validation is blocked. How I did it Add 'cluster' to device_metadata yang models. How to verify it Run UT for sonc-yang-models. Use minigraph parser to generate ConfigDB schema and run yang validation. Signed-off-by: Gang Lv ganglv@microsoft.com
…0.2.5 (#9619) - Why I did it To include latest SDK fixes: 1. On CMIS modules, after low power configuration, the firmware waited for the module state to be ModuleReady instead of ModuleLowPower causing delays. 2. When connecting SN4600C, 100GbE port with CWDM4 module (Gen 3.0), link up time is 30 seconds. and to include SAI fixes \ changes: 1. Reduce verbosity for resource check vendor data not found 2. Fix metadata validation, check default value on conditions check 3. Add 100MB, 10MB to 2201 system 4. L3 VXLAN overlay ECMP 5. VXLAN srcport API implementation 6. Fix scheduler profile null (default values) when set on sub group scheduler group 7. Fix ACL binding restoration when port leaves a LAG 8. Fix route logic for set next hop/action and reference counter for ECMP overlay - How I did it 1. Updated SDK/FW submodule and relevant makefiles with the required versions. 2. Update SAI submodule and relevant makefile with the required version. - How to verify it Build an image and run tests from "sonic-mgmt".
Why I did it the strcpy and buffer allocation is not safe, it corrupts 1 byte on the stack. Depending on the memory layout, it may or may not cause issue immediately. message type is not validated before updating the counter. Which could cause segment fault. How I did it Remove the unsafe strcpy, use config->interface.c_str() instead. Check message type before updating counters. How to verify it The issue (1) caused segment fault on a specific platform. The fix was validated there. Issue (2) was precautionary. Added log in case it triggers.
- Why I did it Python select.select accept a optional timeout value in seconds, however, the value passes to it is a value in millisecond. - How I did it Transfer the value to millisecond. - How to verify it Manual test
- Why I did it Fix issue: 'sx_port_mapping_t' object has no attribute 'slot_id'. sx_port_mapping_t only has attribute slot. - How I did it Change slot_id to slot. - How to verify it Manual test
- Why I did it For SYSTEM READY feature. Currently, there is a booting stage in system health service to indicate that the system is loading SONiC component. This booting stage is no longer needed because SYSTEM READY feature will treat that stage as system "NOT READY". - How I did it 1. Remove booting stage 2. Adjust unit test cases - How to verify it Manual test, Unit test, sonic-mgmt Regression
Master image build break - changes to reviewed and re-merged with appropriate fix
```
======================================================================
FAIL: test_buffers_dell6100_render_template (tests.test_j2files.TestJ2Files)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/sonic/src/sonic-config-engine/tests/test_j2files.py", line 246, in test_buffers_dell6100_render_template
self._test_buffers_render_template('dell', 'x86_64-dell_s6100_c2538-r0', 'Force10-S6100', 'sample-dell-6100-t0-minigraph.xml', 'buffers.json.j2', 'buffers-dell6100.json')
File "/sonic/src/sonic-config-engine/tests/test_j2files.py", line 243, in _test_buffers_render_template
assert filecmp.cmp(sample_output_file, self.output_file)
AssertionError
```
This reverts commit 5334712.
commit history: *6cb43ee2 Fix mclagsyncd out of order initialization (#2112)
#### How I did it Added mclag sonic yang file for the MCLAG enhancements as per HLD: sonic-net/SONiC#596 #### How to verify it try rest APIs #### Description for the changelog Added mclag sonic yang
Enable dbgsym package for dhcpmon. Allow CFLAGS and LDFLAGS from environment variables to be used in the dhcp6relay build. This makes sure that the -O2 flag from dpkg-buildflags gets used. Finally, enable all hardening flags in dpkg-buildflags for dhcp6relay and dhcpmon. The change from the default set of flags is that during linking, immediate binding of symbols is done instead of lazy binding. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
#### Why I did it Include sonic-bgp-monitor to setup.py so it gets included in /usr/local/yang-models when installing the package #### How I did it #### How to verify it install the package #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> #### A picture of a cute animal (not mandatory but encouraged)
#### Why I did it If the grouping is in the same file in the module, fetching the grouping fails #### How I did it fixing the `uses_module_name` when the grouping is under the same file #### How to verify it Enabled a grouping under the same file which is `lldp`, there is a test in sonic-yang-mgmt that translates `sample-config-db` into yang format. This test passes with grouping in `lldp` used. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> #### A picture of a cute animal (not mandatory but encouraged)
Move marvell armhf SAI deb to 1.9.1 to address build failures. Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
… VXLAN src port range feature (#9658) - Why I did it Remove obsolete parameter that enables static VXLAN src port range provide functionality no generate json config file according to appropriate parameter in config_db Done for SN3800: • Mellanox-SN3800-D28C50 • Mellanox-SN3800-C64 • Mellanox-SN3800-D28C49S1 (New 10G SKU) SN2700: • Mellanox-SN2700-D48C8 - How I did it Remove SAI_VXLAN_SRCPORT_RANGE_ENABLE=1 from appropriate sai.profile files Created vxlan.json file and added few params that depends on DEVICE_METADATA.localhost.vxlan_port_range - How to verify it File /etc/swss/config.d/vxlan.json should be generated inside swss docker when it restart [ { "SWITCH_TABLE:switch": { "vxlan_src": "0xFF00", "vxlan_mask": "8" }, "OP": "SET" } ] Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
…400G (#9622) Why I did it Updated the BCM config recommended by Broadcom for Nokia-IXR7250E-36x400G How I did it Updated the BCM config file How to verify it Verified running the image with this BCM config in Nokia-IXR7250E-36x400G and ensured that the syncd container was stable, ports were up and passing the traffic. Signed-off-by: Sakthivadivu Saravanaraj <sakthivadivu.saravanaraj@nokia.com>
Why I did it Fixes #8980 partly. The corresponding changes in sonic-sairedis is here : sonic-net/sonic-sairedis#975 How I did it Include changes from both repos and build an image for verification. How to verify it Trigger fast-reboot with the changes, see the attribute SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL being set at the SAI level. Signed-off-by: Thushar Gowda <24815472+tbgowda@users.noreply.github.com>
53c630b [CoPP] Add always_enabled field to coppmgr logic ([minigraph]: Add PORTCHANNEL_MEMBER configurations #2034) adcf69d [cbf] Fix cbf sync error ([aboot] add SWI_DEFAULT support in boot0 #2056) 69f9ee5 fix mclagsyncd out of order initialization ([submodules] update dbsyncd and snmpagent pointers for LLDP MIB support #2112)
*docker-dhcp-relay: Fix test call to MockConfigDb Signed-off-by: Christian Svensson <blue@cmd.nu>
Signed-off-by: Prince George <prgeor@microsoft.com>
* Remove tm and all dependancies Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * Removed line connected with thermal_manager Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>
VadymYashchenko
pushed a commit
that referenced
this pull request
Mar 8, 2022
Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)