[dhcp6relay] Support relaying Relay-Forward message #9887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
reviewed
Feb 1, 2022
yxieca
reviewed
Feb 1, 2022
src/dhcp6relay/src/relay.h
Outdated
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| #define RELAY_PORT 547 | |||
| #define CLIENT_PORT 546 | |||
| #define HOP_LIMIT 32 | |||
| #define HOP_LIMIT 8 | |||
There was a problem hiding this comment.
Correcting hop limit according to rfc: https://datatracker.ietf.org/doc/html/rfc8415#:~:text=8.%20%20%20Section%207%20(%22DHCP%20Constants%22)%20was%20primarily%20updated%20to%20add%0A%20%20%20%20%20%20%20%20constants%20from%20RFC%204242%20and%20RFC%207083.%20%20Note%20that%20the%20default%0A%20%20%20%20%20%20%20%20HOP_COUNT_LIMIT%20value%20was%20reduced%20from%2032%20to%208.
There was a problem hiding this comment.
Can you add a comment accordingly?
yxieca
reviewed
Feb 1, 2022
yxieca
approved these changes
Feb 1, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Feb 8, 2022
yxieca
pushed a commit
that referenced
this pull request
Feb 10, 2022
|
@kellyyeh - Can we have this fix in 202111 branch? |
kellyyeh
added
the
Request for 202111 Branch
judyjoseph
pushed a commit
that referenced
this pull request
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Included in 201811 Branch
Included in 202012 Branch
Included in 202111 Branch
Request for 201811 Branch 
Request for 202012 Branch
Request for 202111 Branch
For PRs being requested for 202111 branch
Request for 202012 Branch
Request for 202111 Branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Allow dhcp6relay to relay DHCPv6 Relay messages.
How I did it
Encapsulate Relay-Forward message in a new Relay-Forward message. No changes needed on the Relay-Reply from server.
How to verify it
Send a Relay Forward message, check if a new Relay Forward message was constructed and sent to the servers.
Tested with sonic-net/sonic-mgmt#5051
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)