Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system-health] Remove booting stage in system health service #9792

Merged

Conversation

Junchao-Mellanox
Copy link
Collaborator

@Junchao-Mellanox Junchao-Mellanox commented Jan 19, 2022

Depends on sonic-net/sonic-utilities#2022. Suggest merge order:

  1. Merge [system-health] Remove booting stage in system health service sonic-utilities#2022 first
  2. Merge this and update sonic-utilities submodule pointer

Why I did it

For SYSTEM READY feature. Currently, there is a booting stage in system health service to indicate that the system is loading SONiC component. This booting stage is no longer needed because SYSTEM READY feature will treat that stage as system "NOT READY".

How I did it

  1. Remove booting stage
  2. Adjust unit test cases

How to verify it

  1. Manual test
  2. Unit test
  3. sonic-mgmt Regression

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@sg893052
Copy link
Contributor

Looks fine. Thanks!
Now I believe systemready code could be placed in /usr/local/lib/python3.9/dist-packages/health_checker/ and invoked from healthd's run()

@liat-grozovik liat-grozovik merged commit c06cb21 into sonic-net:master Jan 27, 2022
@Junchao-Mellanox Junchao-Mellanox deleted the start-system-health-early branch June 12, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants