Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]Review the translation of the livechat #9966

Closed
wants to merge 3 commits into from

Conversation

renatobecker-zz
Copy link

@RocketChat/core
Closes #9848

The translations of the Livechat widget, admin and settings has been revised.
Some translations were missing both for English and Portuguese.

- Widget
- Admin
- Settings
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9966 March 1, 2018 22:35 Inactive
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations seems to be still inconsistent:

image

image

FYI, running TAPi18n.getLanguage() on console gives me pt-BR

@renatobecker-zz
Copy link
Author

renatobecker-zz commented Mar 5, 2018

Thanks @sampaiodiego for your review.
What's happening is that we have translation files in both the RocketChat folder and the Livechat folder.
So, when the LiveChat is open through the RocketChat port, the LiveChat translation files are not loaded.
I'm looking for the possibility to load the LiveChat translation files when the LiveChat is open through the RocketChat port.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9966 March 7, 2018 20:39 Inactive
@renatobecker-zz
Copy link
Author

renatobecker-zz commented Mar 7, 2018

Hi @sampaiodiego !
As you can see, I made several changes in this PR.
I unified the translation files between LiveChat and RocketChat, so after finished this merger I removed all the translation files we had inside the i18n livechat folder.
Due to this I had to change the configuration of the Livechat TAPi18n, because the package was looking for i18n.json files but they don't exists any more.
So, I followed the package documentation, as you can see by clicking on this link:
https://github.com/TAPevents/tap-i18n#configuring-tap-i18n

I've tried some language translations, such as "pt-BR", "es", "it".. and it's working well.
The problem I've found is that when the browser language is "en", the translation is not working, so I would like you test this language to make sure it's not a problem in my test environment.

I'll be waiting for you review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants