Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Message read receipts #9717

Merged
merged 9 commits into from
Feb 20, 2018
Merged

[NEW] Message read receipts #9717

merged 9 commits into from
Feb 20, 2018

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Feb 14, 2018

Closes #3411

With this PR I'm proposing a new folder structure for features/packages, using new Meteor proposal as well ES2015 imports.
Please let me know what y'll think on this.

About the feature, it starts disabled by default, if enabled it will add a gray check on every message. If it was read by everyone on the room it will turn blue.

There is another setting (also disabled by default) that will start storing the read time of everyone. So you'll be able to see the message's read receipts by looking at the Message info message action.

Please advice on settings label and description, I'm not sure they are clear enough.

Settings

image

Check marks detail

The blue one means read by everyone.
image

New message action to see message info

image

Message info modal

image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9717 February 14, 2018 21:02 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-9717 February 15, 2018 15:50 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-9717 February 15, 2018 17:10 Inactive
@sampaiodiego sampaiodiego changed the title [WIP][NEW] Message read receipts [NEW] Message read receipts Feb 15, 2018
@sampaiodiego
Copy link
Member Author

the PR is ready for merge, I would like to have @RocketChat/core eyes on it pls 😃

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Feb 16, 2018

My only dislike is visual. It seems like putting this there would lead to it being very noisy.

image

Could it maybe be next to time stamp? Maybe on grouped messages could actually show up on hover like the timestamp does?

image

That or right justify it to be in a more consistent place? Imagine every message length is different, the check marks will be all over the page.

Also perhaps a bit smaller?

The other thing is next to join messages those don't seem to be getting updated. So maybe need a way to not apply read receipts to messages based on something in message type definition?

@sampaiodiego
Copy link
Member Author

My only dislike is visual. It seems like putting this there would lead to it being very noisy.

this is how @arthurgiustina designed. I kind of agree with you, but not sure where it should be.

The other thing is next to join messages those don't seem to be getting updated. So maybe need a way to not apply read receipts to messages based on something in message type definition?

I'll have to give this a look, thx

@sampaiodiego
Copy link
Member Author

what do you guys think on having a permission to enable seeing read receipts from other persons? the default might be only for admins, owners and moderators but this would allow people to have more control on this.

so the default would be you can see read receipts for your own messages only, but admins/owners/moderators can see every ones.

@sampaiodiego
Copy link
Member Author

@geekgonecrazy I've changed a few things, please let me know what you think =)

  • check marks are now a bit smaller and on the right, they also turn blue when read by everyone
  • detailed read receipts are under a new message action Message info

@geekgonecrazy
Copy link
Contributor

I'm not sure why that blue is so satisfying. But I like it. Not sure about placement. 🤔

For some reason it not long shows up on my own messages. I wonder if it should only even actually show on own messages? Or maybe configurable.

@sampaiodiego sampaiodiego added this to the 0.62.0 milestone Feb 20, 2018
@rodrigok rodrigok merged commit 3a46e45 into develop Feb 20, 2018
@rodrigok rodrigok deleted the read-receipts branch February 20, 2018 23:51
@graywolf336
Copy link
Contributor

@sampaiodiego glad to see I'm not the only one who has started to use the new es6 features for packages 😉 #nomoreglobals

@rafaelks
Copy link
Contributor

@sampaiodiego Since we're going to implement this feature on the mobile apps, is this new property unread being returned into the message objects (REST and RealTime) API already when the feature is enabled?

Also, could you please work on a new REST API that returns the return of the new Meteor method getReadReceipts @MarcosSpessatto?

@MarcosSpessatto
Copy link
Member

For sure! @rafaelks

@MarcosSpessatto
Copy link
Member

@rafaelks, see #9907 please.

@mohanadrefaai
Copy link

@sampaiodiego @MarcosSpessatto Is there any way to know whether the message is delivered or not?

@sampaiodiego
Copy link
Member Author

@mrqbmrqb no there is not.

@dcook1313
Copy link

I know this thread is older but I was curious if this feature of knowing when people read the message was ever implemented? If so is it available in the free version or just the paid version? thank you.

@sampaiodiego
Copy link
Member Author

@dcook1313 yes it was. you have to enabled it from Admin panel, Message menu and then Show Read Receipts option.

@dcook1313
Copy link

Thank you very much Diego. :)

@GoetheG
Copy link

GoetheG commented Nov 22, 2019

Shouldn't this issue be merged with all the other same isses? Cause this error still occurs with the latest version.
#4957
#15656
#15484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read receipts?
10 participants