Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Endpoint to retrieve message read receipts #9907

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

MarcosSpessatto
Copy link
Member

Closes #9904.
Added endpoint to retrieve message read receipts.

@rafaelks
Copy link
Contributor

I added it to 0.63 because this is something we'll need on the mobile apps.

@winterstefan
Copy link
Contributor

May I humbly ask how exactly you would use this endpoint for a (huge) list of messages & rooms?

we'll need on the mobile apps.

I may have a similar use-case (adding it to a custom chat client based on the Realtime API) and therefore thought about how & when the pull endpoint ('get read status for one message') should be triggered.

Wouldn't some kind of push (e.g. via WebSocket @ Realtime API) make sense to propagate the new read status to other room members?

@rafaelks
Copy link
Contributor

rafaelks commented Mar 8, 2018

@winterstefan That's a great question. Basically, this request will only happen when some user wants to see who read that message. The indication of read is already present in the Message object with the read property.

The RealTime API will indicate the update on the message (read becomes true), but we don't need to know who read it for now.

@winterstefan
Copy link
Contributor

Thank you very much for your fast reply, @rafaelks!

The RealTime API will indicate the update on the message (read becomes true), but we don't need to know who read it for now.

Ah, got it - there it is. I was focussing on subscriptions.

Just tested that with three users in a room - works great! 👍
When all users have read a certain message, the stream-room-message sends a changed event where the message.unread has been removed.

@rodrigok rodrigok merged commit 40f0a70 into develop Mar 27, 2018
@rodrigok rodrigok deleted the feature/rest-api-message-read-receipts branch March 27, 2018 18:18
@rodrigok rodrigok mentioned this pull request Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants