-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append read receipt feature for #3411 #4047
Conversation
Append read receipt info to message entry.
Hey, this is great, but it looks like it depends on the code in your other PR #4048? (for the setMessageReader function) |
Hi @alexdorn87, first of all, thanks by this contribution. I have some questions/suggestions about this PR
@RocketChat/core what do you think? |
This would be a great addition! I agree large rooms this could be very bad for experience. Maybe a setting to only enable for rooms with users <= x ? And let users define it. Then default it to like 10-15 ? |
hi #rodrigok Thanks for your detailed message. I will make it, but now I am some busy. thanks, guys. |
@alexdorn87 can you update all the indentation to TABs? |
If I stepped in and cleaned this pull request up would the RocketChat team be willing to pull it in? This feature is vital for the way my team uses chat, but I don't want to be running a custom version. |
Yes @xavierzwirtz we'd like to add this feature, if you can make the changes, we'd love to merge it. |
Awesome. @alexdorn87, could you post the UI modifications you made somewhere? |
which UI modification do you need? |
The UI for displaying which users have seen a message. I've got the changes you have pushed cleaned up and rebased on tip. Just need the UI changes. |
any progress on this one @alexdorn87 and @xavierzwirtz ? Will be a great new piece of functionality! |
I was able to rebase the changes to the server, and I can see the data getting sent back to the server whenever a message is read. However, I am not familiar with the UI framework that is being used within rocket chat, and have not had time to get familiar with it. I was hoping that @alexdorn87 could post up the UI changes that he made here so that I can get them integrated as well. |
I posted all files. |
@alexdorn87, you said that
Could you post the changes that you made for that? I can get them into a PR and have the RocketChat review them. |
Hi again @alexdorn87 and @xavierzwirtz - is there an easy way forward to complete this PR? Would be a great feature addition to Rocket.chat! |
This would be a great feature addition to Rocket.chat! |
Would love to see this in RC, and completely agree about keeping it disabled by default, and defaulting to only on rooms with a handful of users. |
@sampaiodiego can you link this on the PR you are about to create for this feature? |
Closed via #9717 |
@RocketChat/core
Closes #3411
Append read receipt info to message entry.