Add support for Orbit token bridge #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.5.2
… code duplication
yahgwai
reviewed
Aug 24, 2023
contracts/tokenbridge/ethereum/gateway/L1OrbitReverseCustomGateway.sol
Outdated
Show resolved
Hide resolved
…design Rollup and rollup proxy admin are owned by L1 upgrade executor, on which the rollupOwner has EXECUTOR role. When creating token bridge for rollup, now rollupOwner has to be provided as well. L1 creator will check that rollupOwner has EXECUTOR role on the upgrade executor (which is fetched via .owner()). Aliased L1 upgrade executor and rollup owner are then made executors on L2 upgrade executor.
Add UpgradeExecutor to token bridge creation flow
Derive token bridge addresses on child chain from chain ID
Add support to do single-TX deployment of token bridge for fee token based Orbit chains
This function uses the fee paying token instead of ETH for fees
Make sure ether is not sent in ERC20 token bridge
setGateways() in OrbitGatewayRouter should not be payable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for token bridge for Orbit (ERC20-based) rollups where custom token is used to pay for fees.
Implementation is done mainly in new Orbit-specific contracts which inherit from their "standard" counterparts.
Ie.:
Bridging of rollup's native fee token through token bridge is not allowed. It can only be bridged through inbox directly, and in that case it is minted on L2 side as native currency.
Also Includes: