Add UpgradeExecutor to token bridge creation flow #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahgwai
reviewed
Aug 28, 2023
| // transfer ownership to rollup's owner | ||
| ProxyAdmin(proxyAdmin).transferOwnership(rollupOwner); | ||
| // deploy multicall | ||
| Create2.deploy(0, _getL2Salt(OrbitSalts.L2_MULTICALL), _creationCodeFor(l2Code.multicall)); |
There was a problem hiding this comment.
Should we use a proxy in case the multicall implementation changes? Or has it been stable for a long time?
There was a problem hiding this comment.
hmm good q, not sure if it is worth it. Arb multicall hasn't been changed last 2 year as far as I can see. @gzeoneth what do you think?
…design Rollup and rollup proxy admin are owned by L1 upgrade executor, on which the rollupOwner has EXECUTOR role. When creating token bridge for rollup, now rollupOwner has to be provided as well. L1 creator will check that rollupOwner has EXECUTOR role on the upgrade executor (which is fetched via .owner()). Aliased L1 upgrade executor and rollup owner are then made executors on L2 upgrade executor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On L1 side of token bridge: use existing rollup's proxy admin (fetch it from inbox).
On L2 side of token bridge: create new proxy admin for L2 contracts. Also create new UpgradeExecutor. Executor is the owner of proxy admin. Rollup owner and aliased L1 executor have EXECUTOR role.
Note: 'Test token bridge deployment' test which targets nitro test node is failing because test node is rn not fully adapted to work with latest contract changes.