Add support to do single-TX deployment of token bridge for fee token based Orbit chains #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahgwai
approved these changes
Aug 28, 2023
…design Rollup and rollup proxy admin are owned by L1 upgrade executor, on which the rollupOwner has EXECUTOR role. When creating token bridge for rollup, now rollupOwner has to be provided as well. L1 creator will check that rollupOwner has EXECUTOR role on the upgrade executor (which is fetched via .owner()). Aliased L1 upgrade executor and rollup owner are then made executors on L2 upgrade executor.
Add UpgradeExecutor to token bridge creation flow
Derive token bridge addresses on child chain from chain ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entrypoint is still the same -
function createTokenBridge(address inbox, uint256 maxGasForContracts, uint256 gasPriceBid)inL1AtomicTokenBridgeCreator.Function will figure out if ETH or ERC20 token is used to pay for retryable fees and do the appropriate calls. If ERC20 fee token used, it is expected that amount needed to pay for retryables is already approved (msg.sender needs to approve
L1AtomicTokenBridgeCreatorto spend them). Creator will then move fee tokens to inbox.Scripts for deploying creator and creating token bridges are included.
Ie. to deploy creator on Arbitrum goerli, first prepare
.env, then run:yarn run deploy:goerli:token-bridge-creatorTo create new token bridge for Orbit chain run this with rollup address as argument:
yarn run create:goerli:token-bridge -- '0x05615057779Fda653f18469FcF2e87d0A02B815E'To test deployment set endpoints in .env, and have local
network.jsonfile with addresses, then run:yarn run test:tokenbridge:deployment