Enable (un-hide) the Conversion Hosts tab of the Settings page #922

mturley · 2019-03-27T18:47:30Z

This PR exposes the Conversion Hosts list view and wizard by removing the flag that prevented the Conversion Hosts tab from rendering. We should merge it only when the back end is ready and the feature is ready for release.

@fdupont-redhat wanted us to wait until he gives the green light after he tests the changes to the enablement playbook.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1695356

miq-bot · 2019-03-27T18:58:38Z

Checked commit mturley@24b43d5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

djberg96 · 2019-03-29T12:12:56Z

@mturley My piece is merged. :)

ghost · 2019-03-29T14:39:35Z

We still need to validate that the enablement task works flawlessly before activating the feature in the UI. It's going to require some thorough testing :)

mturley · 2019-04-01T14:18:00Z

@fdupont-redhat we should definitely test the back end task thoroughly before enabling the UI, but I also want to make sure we leave enough time after enabling the UI for QE to test it thoroughly as well.

mturley · 2019-04-05T15:59:00Z

This PR depends on all the changes in https://bugzilla.redhat.com/show_bug.cgi?id=1622728, and should not be backported until we have a resolution on that BZ's PRs. @fdupont-redhat, when we are confident that the back end on the hammer branch fully supports conversion host enablement, can you help me track that and update this PR and its BZ?

mturley · 2019-04-05T16:51:23Z

To be more precise (and we can update this as the back end situation changes), this PR depends on all of the following PRs (also listed in https://docs.google.com/spreadsheets/d/1LA1QC7vaPyohRZFu9IM8d3o3TZHUk4dBrf7bXFrloUU/edit#gid=0):

mturley · 2019-04-18T18:02:39Z

@mzazrivec it sounds like the back end parts for this are all merged now, so we should merge this ASAP to try and get it into the next build.

mturley · 2019-04-18T19:11:18Z

Making an exception to the usual rule and self-merging this to make sure it gets into Monday's build.

mturley · 2019-04-25T17:16:34Z

For posterity, these are all the UI related pull requests leading up to this one, which we used to build this feature in smaller pieces:

#851 (Add the Conversion Hosts tab, disabled/hidden)
#858 (Add skeleton for page components)
#863 (Add skeleton for wizard steps)
#864 (Add empty state screen)
#871 (Wizard step 1)
#874 (List view phase 1)
#876 (Wizard step 2)
#880 (Wizard step 3)
#883 (Wizard step 4)
#882 (List view phase 2)
#894 (Wizard field fix)
#889 (List view phase 3)
#907 (List view state fix)
#908 (Wizard API param change 1)
#909 (List view remove modal change)
#913 (Wizard API param change 2)
#916 (List view retry button modal)
#924 (Set the auth_user to 'root' for RHV hosts)
#928 (Unit tests for helpers)

mturley · 2019-04-25T17:33:27Z

@JPrause when we add this to the changelog for hammer-6 we should just call it "Add Conversion Hosts tab to Settings page", to summarize all of the other PRs leading up to it that we're not including individually.

Enable (un-hide) the Conversion Hosts tab of the Settings page (cherry picked from commit c0da5af) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1703104

simaishi · 2019-04-25T19:21:18Z

Hammer backport details:

$ git log -1
commit c949f5ba41e3faed42803e64adb3e88ab57fae35
Author: Mike Turley <mike.turley@alum.cs.umass.edu>
Date:   Thu Apr 18 15:11:23 2019 -0400

    Merge pull request #922 from mturley/enable-conversion-hosts-page
    
    Enable (un-hide) the Conversion Hosts tab of the Settings page
    
    (cherry picked from commit c0da5aff9002135c4f14735e147e470ec0277580)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1703104

…page" This reverts commit c949f5b. https://bugzilla.redhat.com/show_bug.cgi?id=1703104

simaishi · 2019-05-09T20:10:13Z

Reverted the hammer backport:

commit 95934a17160c59b188959baf451cdabbe453b8d9
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Thu May 9 16:08:50 2019 -0400

    Revert "Merge pull request #922 from mturley/enable-conversion-hosts-page"
    
    This reverts commit c949f5ba41e3faed42803e64adb3e88ab57fae35.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1703104

Enable (un-hide) the Conversion Hosts tab of the Settings page (cherry picked from commit c0da5af) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1703104

simaishi · 2019-05-20T18:45:05Z

Re-backported to hammer:

$ git log -1
commit 371422bf62c052b75a319855cf5359c8fc5b6c6f
Author: Mike Turley <mike.turley@alum.cs.umass.edu>
Date:   Thu Apr 18 15:11:23 2019 -0400

    Merge pull request #922 from mturley/enable-conversion-hosts-page
    
    Enable (un-hide) the Conversion Hosts tab of the Settings page
    
    (cherry picked from commit c0da5aff9002135c4f14735e147e470ec0277580)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1703104

Enable (un-hide) the Conversion Hosts tab of the Settings page

24b43d5

mturley added enhancement bz Issues filed by QE or having a BZ hammer/yes z-stream v1.2 labels Mar 27, 2019

mzazrivec mentioned this pull request Apr 5, 2019

Conversion Host: list view phase 2 #882

Merged

mturley requested a review from mzazrivec April 18, 2019 17:56

mturley assigned mzazrivec Apr 18, 2019

mturley merged commit c0da5af into ManageIQ:master Apr 18, 2019

mturley deleted the enable-conversion-hosts-page branch April 18, 2019 19:11

This was referenced Apr 18, 2019

[Changelog] Update for Hammer-5 release #939

Merged

[Changelog] Removing PRs from changelog #946

Merged

mturley added the changelog/yes label Apr 25, 2019

simaishi added hammer/backported and removed hammer/yes labels Apr 25, 2019

simaishi added a commit that referenced this pull request May 9, 2019

Revert "Merge pull request #922 from mturley/enable-conversion-hosts-…

95934a1

…page" This reverts commit c949f5b. https://bugzilla.redhat.com/show_bug.cgi?id=1703104

simaishi added hammer/yes and removed hammer/backported labels May 9, 2019

simaishi added hammer/backported and removed hammer/yes labels May 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable (un-hide) the Conversion Hosts tab of the Settings page #922

Enable (un-hide) the Conversion Hosts tab of the Settings page #922

mturley commented Mar 27, 2019 •

edited

Loading

miq-bot commented Mar 27, 2019

djberg96 commented Mar 29, 2019

ghost commented Mar 29, 2019

mturley commented Apr 1, 2019

mturley commented Apr 5, 2019

mturley commented Apr 5, 2019 •

edited

Loading

mturley commented Apr 18, 2019

mturley commented Apr 18, 2019

mturley commented Apr 25, 2019 •

edited

Loading

mturley commented Apr 25, 2019

simaishi commented Apr 25, 2019

simaishi commented May 9, 2019

simaishi commented May 20, 2019

Enable (un-hide) the Conversion Hosts tab of the Settings page #922

Enable (un-hide) the Conversion Hosts tab of the Settings page #922

Conversation

mturley commented Mar 27, 2019 • edited Loading

miq-bot commented Mar 27, 2019

djberg96 commented Mar 29, 2019

ghost commented Mar 29, 2019

mturley commented Apr 1, 2019

mturley commented Apr 5, 2019

mturley commented Apr 5, 2019 • edited Loading

mturley commented Apr 18, 2019

mturley commented Apr 18, 2019

mturley commented Apr 25, 2019 • edited Loading

mturley commented Apr 25, 2019

simaishi commented Apr 25, 2019

simaishi commented May 9, 2019

simaishi commented May 20, 2019

mturley commented Mar 27, 2019 •

edited

Loading

mturley commented Apr 5, 2019 •

edited

Loading

mturley commented Apr 25, 2019 •

edited

Loading