Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2V] Fix placeholder name for conversion hosts #18535

Merged
merged 1 commit into from
Mar 8, 2019
Merged

[V2V] Fix placeholder name for conversion hosts #18535

merged 1 commit into from
Mar 8, 2019

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented Mar 7, 2019 •
edited
Loading

The placeholder for notification messages in the notification_types.yml needs to match what we use internally within ConversionHost::Configurations, which is op_arg. You can see that used here:

https://github.com/ManageIQ/manageiq/blob/master/app/models/conversion_host/configurations.rb#L9

Can use https://bugzilla.redhat.com/show_bug.cgi?id=1622728 for backport.

https://bugzilla.redhat.com/show_bug.cgi?id=1695818

@djberg96
Copy link
Contributor Author

djberg96 commented Mar 7, 2019

@mturley Please take a look.

@miq-bot
Copy link
Member

miq-bot commented Mar 7, 2019

Checked commit https://github.com/djberg96/manageiq/commit/de0c70b1af52cbfe61f838436cba5d1de8dafb07 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

mturley
mturley approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for the quick fix

@Fryguy Fryguy merged commit 3af5a8f into ManageIQ:master Mar 8, 2019
@Fryguy Fryguy self-assigned this Mar 8, 2019
@Fryguy Fryguy added this to the Sprint 107 Ending Mar 18, 2019 milestone Mar 8, 2019
@djberg96
Copy link
Contributor Author

@miq-bot add_label hammer/yes

@mturley mturley mentioned this pull request Apr 5, 2019
Merged
simaishi pushed a commit that referenced this pull request Apr 22, 2019
@Fryguy @simaishi
Merge pull request #18535 from djberg96/conversion_host_notifications
d003c2d 
[V2V] Fix placeholder name for conversion hosts

(cherry picked from commit 3af5a8f)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702054
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit d003c2df6504247d2168b5459cc36765bbae4c5e
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Mar 8 12:31:48 2019 -0500

    Merge pull request #18535 from djberg96/conversion_host_notifications
    
    [V2V] Fix placeholder name for conversion hosts
    
    (cherry picked from commit 3af5a8ffc0092761295c32cbabfa418ebe9fe248)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturley mturley mturley approved these changes

Assignees

@Fryguy Fryguy

Labels
bug hammer/backported v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@djberg96 @miq-bot @simaishi @mturley @Fryguy