Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Conversion Host Configuration Wizard - Properly pass SSH keys and VDDK path to API #908

Merged
merged 3 commits into from
Mar 14, 2019

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Mar 13, 2019

Part of the Conversion Hosts UI feature BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1693339

Closes #898.
Closes #899.

This PR also adds the word "private" to the labels for Conversion Host SSH private key and VMware hypervisors SSH private key:

Screenshot 2019-03-13 17 16 46

This corresponds to API support introduced by ManageIQ/manageiq#18537 and ManageIQ/manageiq#18309.

@mturley mturley added enhancement bz Issues filed by QE or having a BZ v1.1 hammer/yes z-stream labels Mar 13, 2019
@mturley mturley requested a review from mzazrivec March 13, 2019 21:14
@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2019

Checked commits mturley/manageiq-v2v@faa6c94~...5928e32 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Mar 14, 2019
@mzazrivec mzazrivec merged commit e65d65e into ManageIQ:master Mar 14, 2019
@mturley mturley deleted the conv-host-wizard-ssh-keys branch March 14, 2019 19:15
@mturley mturley added v1.2 and removed v1.1 labels Mar 25, 2019
simaishi pushed a commit that referenced this pull request Apr 5, 2019
Conversion Host Configuration Wizard - Properly pass SSH keys and VDDK path to API

(cherry picked from commit e65d65e)

https://bugzilla.redhat.com/show_bug.cgi?id=1696423
@simaishi
Copy link
Contributor

simaishi commented Apr 5, 2019

Hammer backport details:

$ git log -1
commit 0951eb76f87d1ac17ef7429c14c08ac59de946a5
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Mar 14 10:45:07 2019 +0100

    Merge pull request #908 from mturley/conv-host-wizard-ssh-keys
    
    Conversion Host Configuration Wizard - Properly pass SSH keys and VDDK path to API
    
    (cherry picked from commit e65d65ea6dd511b62bae5121ea526f0077f4e368)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1696423

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants