Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVMENTS] User-Requested Modifications #261

Merged
merged 30 commits into from
Oct 2, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Oct 2, 2021

Lissy93 /IMPROVMENTS/user-requested-modifications → Lissy93/dashy Commits: 30 | Files Changed: 36 | Additions: 422 ✨ Feature 🐛 Fix 🚚 Refactor Powered by Pull Request Badge

Category: Bugfix / Feature / Refactoring Only / Build related changes / Documentation

Overview
A whole bunch of small updates that were requested in recent issues

Issue Number: #163 #250 #254 #255 #259

New Vars

Field Type Required Description
appConfig.workspaceLandingUrl string Optional The URL or an app, service or website to launch when the workspace view is opened, before another service has been launched
appConfig.colCount number Optional The number of columns of sections displayed on the homepage, using the default view, as an integer between 1 and 8

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Oct 2, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: e8b7ee1

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6158b6ad84407000073df5b8

😎 Browse the preview: https://deploy-preview-261--dashy-dev.netlify.app

@liss-bot
Copy link
Collaborator

liss-bot commented Oct 2, 2021

Hi Lissy93! Thank you for contributing to Dashy! ✨

When making changes to the documentation, be sure to double check that:

  • Link and images URLs properly resolve
  • Your spelling and grammar is correct
  • Any markdown formatting is valid

Don't forget to verify they the config validator script responds correctly to your new attribute.

Thank you for contributing to Dashy's themes 🎨


I'm a bot, and this is an automated comment 🤖

@viezly
Copy link

viezly bot commented Oct 2, 2021

This pull request is split into 6 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • .github
  • .github/workflows
  • /
  • docs
  • src/components
  • src/styles
  • src/utils
  • src/views

@liss-bot liss-bot added the size/l label Oct 2, 2021
@lgtm-com
Copy link

lgtm-com bot commented Oct 2, 2021

This pull request fixes 2 alerts when merging c896120 into cf92331 - view on LGTM.com

fixed alerts:

  • 2 for Inefficient regular expression

Repository owner deleted a comment from liss-bot Oct 2, 2021
@Lissy93 Lissy93 removed the size/l label Oct 2, 2021
Repository owner deleted a comment from liss-bot Oct 2, 2021
Repository owner deleted a comment from lgtm-com bot Oct 2, 2021
Repository owner deleted a comment from lgtm-com bot Oct 2, 2021
Repository owner deleted a comment from lgtm-com bot Oct 2, 2021
Repository owner deleted a comment from lgtm-com bot Oct 2, 2021
Repository owner deleted a comment from lgtm-com bot Oct 2, 2021
@liss-bot
Copy link
Collaborator

liss-bot commented Oct 2, 2021

Size Change: +443 B (0%)

Total Size: 1.89 MB

Filename Size Change
./dist/css/dashy.********.css 20.7 kB +136 B (+1%)
./dist/js/dashy.********.js 97.2 kB +303 B (0%)
./dist/precache-********.138b5aec6bdfe419f28c86b9ea19b410.js 0 B -3.46 kB (removed) 🏆
./dist/precache-********.f622c4e26064b0311032ca26ccd277c5.js 3.46 kB +3.46 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./dist/css/chunk-********.a64c098d.css 348 B 0 B
./dist/css/chunk-********.f5d4b402.css 899 B 0 B
./dist/css/chunk-********.974ecc90.css 98 B 0 B
./dist/css/chunk-vendors.********.css 847 B 0 B
./dist/default.html 2.61 kB 0 B
./dist/index.html 1.09 kB +2 B (0%)
./dist/js/chunk-********.db9652fc.js 2.05 kB 0 B
./dist/js/chunk-********.087feb1d.js 591 B 0 B
./dist/js/chunk-********.ff8ef00c.js 437 B 0 B
./dist/js/chunk-vendors.********.js 1.76 MB 0 B
./dist/service-worker.js 620 B +1 B (0%)

compressed-size-action

Repository owner deleted a comment from liss-bot Oct 2, 2021
Repository owner deleted a comment from liss-bot Oct 2, 2021
Repository owner deleted a comment from liss-bot Oct 2, 2021
@Lissy93 Lissy93 added ✨ New Feature [PR] Contains implementation of a new feature 🏗️ Architectural Changes [PR] Updates to application architecture, data flow or structure 🚚 Refactor [PR] Non-feature code-related updates and refactoring 🦋 Bug Fix [PR] Code includes bug fixes labels Oct 2, 2021
@lgtm-com
Copy link

lgtm-com bot commented Oct 2, 2021

This pull request fixes 2 alerts when merging e8b7ee1 into cf92331 - view on LGTM.com

fixed alerts:

  • 2 for Inefficient regular expression

@Lissy93 Lissy93 merged commit 9b1c457 into master Oct 2, 2021
@Lissy93 Lissy93 deleted the IMPROVMENTS/user-requested-modifications branch October 2, 2021 19:51
@Lissy93 Lissy93 restored the IMPROVMENTS/user-requested-modifications branch October 2, 2021 19:58
@Lissy93 Lissy93 deleted the IMPROVMENTS/user-requested-modifications branch October 28, 2021 11:30
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#261

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗️ Architectural Changes [PR] Updates to application architecture, data flow or structure 🦋 Bug Fix [PR] Code includes bug fixes ✨ New Feature [PR] Contains implementation of a new feature 🟧 PR - Large 🚚 Refactor [PR] Non-feature code-related updates and refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants