Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Workspace view item launch in new tab #254

Closed
jhelmink opened this issue Sep 27, 2021 · 1 comment
Closed

[FEATURE_REQUEST] Workspace view item launch in new tab #254

jhelmink opened this issue Sep 27, 2021 · 1 comment
Assignees
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change 👩‍💻 Good First Issue [ISSUE] Great task for newcomers to work on

Comments

@jhelmink
Copy link

Is your feature request related to a problem? If so, please describe.

When in Workspace view the per item target: newtab option is ignored and dashy will try to load the target URL into the workspace view. I think this should be honored because usually this is applied to things that don't/won't work in iFrames.

Describe the solution you'd like

If target: newtab is set it should be used even when in workspace view.

Priority

Low (Nice-to-have)

Is this something you would be keen to implement

No

@jhelmink jhelmink added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Sep 27, 2021
@Lissy93 Lissy93 self-assigned this Sep 27, 2021
@Lissy93 Lissy93 added the 👩‍💻 Good First Issue [ISSUE] Great task for newcomers to work on label Sep 27, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Sep 27, 2021

Good point, will do this at the same time as #255 :)

@Lissy93 Lissy93 closed this as completed in 9b1c457 Oct 2, 2021
asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change 👩‍💻 Good First Issue [ISSUE] Great task for newcomers to work on
Projects
None yet
Development

No branches or pull requests

2 participants