Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Favicon not loading, console errors #163

Closed
evroon opened this issue Aug 15, 2021 · 11 comments · Fixed by #273
Closed

[BUG] Favicon not loading, console errors #163

evroon opened this issue Aug 15, 2021 · 11 comments · Fixed by #273
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed 🔨 Fixed 💤 Low Priority [ISSUE] Nice to have, but not currently in scope 🛩️ Released 1.9.0

Comments

@evroon
Copy link
Contributor

evroon commented Aug 15, 2021

The Favicon is not loading for me on Firefox, which did work a while ago.
Also,

It returns 404s for:

  • <domain>/img/icons/apple-touch-icon-152x152.png
  • <domain>/img/icons/favicon-16x16.png

Also, Firefox says the mime type of a stylesheet is incorrect:
The stylesheet https://<domain>/# was not loaded because its MIME type, “text/html”, is not “text/css”.

Chrome does not give the error above, but another error:
InitServiceWorker.js:82 Error during service worker registration: TypeError: Failed to register a ServiceWorker for scope ('https://<domain>/') with script ('https://<domain>/service-worker.js'): ServiceWorker script evaluation failed

I run Dashy 1.5.9 using the arm32v7 Docker image on a Raspberry pi.

@evroon evroon added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Aug 15, 2021
@MilesTEG1
Copy link

Hello,
I don't have the dashy favicon too but only with Firefox, it's present with MS Edge...
Is there a way to have it in firefox ?

@drag0n141
Copy link

I have the Problem too with the "generative" Icons.

@jhelmink
Copy link

The generative icons API/Server has gone down. This should be removed from the docs.

favicons are coded in lots of different ways for different apps and sites, suggest you specify a manual URL for the ico/png, or use icon: si-firefox

https://github.com/Lissy93/dashy/blob/master/docs/icons.md

@Lissy93
Copy link
Owner

Lissy93 commented Oct 2, 2021

Thank you @jhelmink for the heads up about the Generative Icons no longer working.

Have made an update in #261 for V-1.8.5 to point it to a new API, so this should now be working again :)

@liss-bot liss-bot added the 👍 Top 10 Issue! [ISSUE] Auto applied to tickets with the most user reactions label Oct 8, 2021
@Lissy93 Lissy93 added 💤 Low Priority [ISSUE] Nice to have, but not currently in scope and removed 👍 Top 10 Issue! [ISSUE] Auto applied to tickets with the most user reactions labels Oct 9, 2021
@evroon
Copy link
Contributor Author

evroon commented Oct 10, 2021

The generative icons API/Server has gone down. This should be removed from the docs.

favicons are coded in lots of different ways for different apps and sites, suggest you specify a manual URL for the ico/png, or use icon: si-firefox

https://github.com/Lissy93/dashy/blob/master/docs/icons.md

I'm a bit confused by this. I think you are talking about fetching favicons of services that are displayed in Dashy. I was talking about the favicon of Dashy itself, which is part of this repository and is (AFAIK) not fetched from an external source.

🚀 A dashboard for your homelab. Contribute to Lissy93/dashy development by creating an account on GitHub.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 10, 2021
@evroon
Copy link
Contributor Author

evroon commented Oct 10, 2021

In the html, there are two favicons that return 404s:

<link rel="icon" type="image/png" sizes="16x16" href="/img/icons/favicon-16x16.png">
<link rel="apple-touch-icon" href="/img/icons/apple-touch-icon-152x152.png">

@Lissy93
Copy link
Owner

Lissy93 commented Oct 10, 2021

Yup, you are right - I was just replying to drag0n141 and Josh, who mentioned that generative icons were not working. Separate issue, I know.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 10, 2021
@Lissy93 Lissy93 added the ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed label Oct 15, 2021
@liss-bot
Copy link
Collaborator

Hello @evroon! It looks like all or part of this issue has now been implemented :) If you're enjoying Dashy, please consider supporting the project- for ways to get involved, see Contributing 💖


I am a bot, and this is an automated message 🤖

@evroon
Copy link
Contributor Author

evroon commented Oct 16, 2021

Thank you @Lissy93 !

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 16, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Oct 16, 2021

No problem :) Sorry it took me so long to get this fixed

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 16, 2021
@liss-bot
Copy link
Collaborator

The fix for this issue has now been released in Dashy 1.9.0 ✨

If you haven't done so already, please update your instance to 1.9.0 or later. See Dashy 1.9.0 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
Closes Lissy93#163

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed 🔨 Fixed 💤 Low Priority [ISSUE] Nice to have, but not currently in scope 🛩️ Released 1.9.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants