-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Favicon not loading, console errors #163
Comments
Hello, |
I have the Problem too with the "generative" Icons. |
The favicons are coded in lots of different ways for different apps and sites, suggest you specify a manual URL for the ico/png, or use https://github.com/Lissy93/dashy/blob/master/docs/icons.md |
I'm a bit confused by this. I think you are talking about fetching favicons of services that are displayed in Dashy. I was talking about the favicon of Dashy itself, which is part of this repository and is (AFAIK) not fetched from an external source.
|
In the html, there are two favicons that return 404s: <link rel="icon" type="image/png" sizes="16x16" href="/img/icons/favicon-16x16.png">
<link rel="apple-touch-icon" href="/img/icons/apple-touch-icon-152x152.png"> |
Yup, you are right - I was just replying to drag0n141 and Josh, who mentioned that generative icons were not working. Separate issue, I know. |
Hello @evroon! It looks like all or part of this issue has now been implemented :) If you're enjoying Dashy, please consider supporting the project- for ways to get involved, see Contributing 💖
|
Thank you @Lissy93 ! |
No problem :) Sorry it took me so long to get this fixed |
The fix for this issue has now been released in Dashy 1.9.0 ✨ If you haven't done so already, please update your instance to Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project. |
Closes Lissy93#163 Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
The Favicon is not loading for me on Firefox, which did work a while ago.
Also,
It returns 404s for:
<domain>/img/icons/apple-touch-icon-152x152.png
<domain>/img/icons/favicon-16x16.png
Also, Firefox says the mime type of a stylesheet is incorrect:
The stylesheet https://<domain>/# was not loaded because its MIME type, “text/html”, is not “text/css”.
Chrome does not give the error above, but another error:
InitServiceWorker.js:82 Error during service worker registration: TypeError: Failed to register a ServiceWorker for scope ('https://<domain>/') with script ('https://<domain>/service-worker.js'): ServiceWorker script evaluation failed
I run Dashy 1.5.9 using the arm32v7 Docker image on a Raspberry pi.
The text was updated successfully, but these errors were encountered: