Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach version_ to checkpoint path only if version is int #1748

Merged
merged 1 commit into from
May 6, 2020
Merged

Attach version_ to checkpoint path only if version is int #1748

merged 1 commit into from
May 6, 2020

Conversation

yukw777
Copy link
Contributor

@yukw777 yukw777 commented May 6, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • N/A Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1659.

We should only attach the prefix version_ to the default checkpoint path when the logger's version is an integer.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented May 6, 2020

Hello @yukw777! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-06 15:25:13 UTC

@mergify mergify bot requested a review from a team May 6, 2020 15:20
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #1748 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1748   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          69      69           
  Lines        4156    4157    +1     
======================================
+ Hits         3666    3667    +1     
  Misses        490     490           

@williamFalcon williamFalcon merged commit 8518663 into Lightning-AI:master May 6, 2020
@yukw777 yukw777 deleted the bugfix/1659_version-name branch May 6, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkpoint adding "version_" at the start of the logger name
3 participants