Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder names inconsistent if version is string and using TensorBoardLogger #1681

Closed
hjalmarlucius opened this issue Apr 30, 2020 · 2 comments
Labels
won't fix This will not be worked on

Comments

@hjalmarlucius
Copy link

hjalmarlucius commented Apr 30, 2020

A) According to TensorBoardLogger, if version is a string then it is used as the run-specific subdirectory name, otherwise 'version_${version}' is used.
B) However, in the callback 'version_${version}' is always used.

LINKS:
A) https://github.com/PyTorchLightning/pytorch-lightning/blob/8b82ce09039e75f3fcb77a987c964249e38def3b/pytorch_lightning/loggers/tensorboard.py#L40
B) https://github.com/PyTorchLightning/pytorch-lightning/blob/3e8f2d99a9951bfb5fc67a98614128317913be1d/pytorch_lightning/trainer/callback_config.py#L55

Edit: This issue comes up as I generally use git commit IDs as version numbers.

@CarloLucibello
Copy link

this has been recently fixed in #1748

@stale
Copy link

stale bot commented Jul 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jul 10, 2020
@stale stale bot closed this as completed Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants