Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint adding "version_" at the start of the logger name #1659

Closed
Etienne-Meunier opened this issue Apr 29, 2020 · 1 comment · Fixed by #1748
Closed

Checkpoint adding "version_" at the start of the logger name #1659

Etienne-Meunier opened this issue Apr 29, 2020 · 1 comment · Fixed by #1748
Labels
feature Is an improvement or enhancement

Comments

@Etienne-Meunier
Copy link

To reproduce :

logger = pl.loggers.TensorBoardLogger(
                save_dir='.',
                version='my_name'
                name='lightning_logs'
            )

trainer = pl.Trainer(logger=logger, log_gpu_memory='all', max_epochs=10)

Giving as a result:

  • /lightning_logs/my_name: Where is saved the logs
  • /lightning_logs/version_my_name : Where is saved the checkpoints

Possible Explanation:
It seems like the checkpoint saving add "version_" to the start of the name even if the name have been given as a parameter :

https://github.com/PyTorchLightning/pytorch-lightning/blob/3e8f2d99a9951bfb5fc67a98614128317913be1d/pytorch_lightning/trainer/callback_config.py#L52-L57

Even if in the Tensorboard Logger if the name is provided there is no "version_" prefix :

https://github.com/PyTorchLightning/pytorch-lightning/blob/8b82ce09039e75f3fcb77a987c964249e38def3b/pytorch_lightning/loggers/tensorboard.py#L81

@github-actions
Copy link
Contributor

Hi! thanks for your contribution!, great first issue!

@Borda Borda added the feature Is an improvement or enhancement label May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants