Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Java11gtk3 #5322

Closed
wants to merge 39 commits into from
Closed

[WIP] Java11gtk3 #5322

wants to merge 39 commits into from

Conversation

LyzardKing
Copy link
Collaborator

This commmit removes the extra java libraries, since jlink inludes them in the bundle.
It also uses the new snapcraft syntax to assign the version and the gnome base
I've been using it to test it on my system, and it seems to work.
The reduction in size is from 391MB to 237MB.
It did need more tweaks in the plugin, so before merging I'd like to hear from the snapcraf team if the change might be accepted upstream.
If not there might be another change we can do in the snapcraft.yaml file, to avoid changing the plugin


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

tobiasdiez and others added 5 commits September 14, 2019 11:03
Bumps com.github.ben-manes.versions from 0.24.0 to 0.25.0.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@Siedlerchr Siedlerchr added the os: snap When JabRef is run as a snap on linux label Sep 16, 2019
@Siedlerchr Siedlerchr changed the title Java11gtk3 [iWIP] Java11gtk3 Sep 16, 2019
@Siedlerchr Siedlerchr changed the title [iWIP] Java11gtk3 [WIP] Java11gtk3 Sep 16, 2019
Siedlerchr and others added 9 commits September 16, 2019 20:45
…ditor to mvvm (JabRef#5315)

* Initial, Fix double list, setValues to Background, Templates and ExportSort

* Fixes in ExportSorting

* Fixes, Cleanups, EntryEditorTab, TableTab

* Added ImportTab

* Fixes wrong encoding

* Reverse encoding fix

* Checkstyle

* Checkstyle

* Fixed l10n, fixes checkstyle-config

* Fixes after review

* Cleanup missed superflous viewModel-casts and lambda-bodies

* Don't set values using background task
Fixes JabRef#5327. The problem was that `getTreeTableRow.getItem()` in `ViewModelTreeTableCellFactory` still returned the old item (and not the new one passed as method argument to `updateItem`).

 Since I was already looking at the code, this PR also fixes JabRef#3112 that improves the coloring after an entry was added to the group.
Improve group coloring and item count
* Fix problem with search and switching between libraries

Fixes JabRef#4846 by using bindings instead of listeners.

* Remove wrong javadoc
…abRef#5338)

* Fix NPE when opening a non existing file from the recent files menu

dialogService object was null, because the FileHistoryMenu class is initialized before the ctor of JabRef frame creates the dialog service object

* fix checkstyle

* Revert "fix checkstyle"

This reverts commit 644b1e0.

* initialize FileHistoryMenu in ctor

* pass opendatabase action instead of JabRef Frame
@koppor
Copy link
Member

koppor commented Sep 21, 2019

@LyzardKing Did you file a PR against the snapcraft repository to get feedback on your changes to the snapcraft gradle plugin?

@LyzardKing
Copy link
Collaborator Author

Yes, it's canonical/snapcraft#2710

matthiasgeiger and others added 6 commits September 22, 2019 14:35
Bumps fontbox from 2.0.16 to 2.0.17.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [src/main/resources/csl-styles](https://github.com/citation-style-language/styles) from `0581021` to `7ac5e43`.
- [Release notes](https://github.com/citation-style-language/styles/releases)
- [Commits](citation-style-language/styles@0581021...7ac5e43)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps pdfbox from 2.0.16 to 2.0.17.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Siedlerchr and others added 14 commits September 23, 2019 14:33
fix encoding issues in xjc code generation
* Fix exception when closing JabRef

Fixes JabRef#5348 by using JavaFX windows instead of awt windows.

* In fact, just do nothing 

We cannot iterate over the windows as the might be gone already (when the event is called from closing a window).

* Update JabRefFrame.java
As explained in JabRef#5254 (comment) it is no longer possible to customize the context menu items, because the classes related to the text field behavior are not accessible. Thus, instead I simply copied the relevant code from openjdk. Pretty ugly workaround... Fixes JabRef#5254 and refs javafxports/openjdk-jfx#583.

Moreover, I removed the custom tab handling because it is now working as expected (i.e. JabRef#2902 is fixed in Java 9+).
Fixes JabRef#5022. Problem was that the pseudo-class was not initialized correctly but was only triggered upon changes.
Now groups have a dark gray instead of white as their default color. Fixes JabRef#4868.
* Initial try

* Update gradle.yml

* Post to build.jabref.org

* Update gradle.yml

* Delete upload-to-builds.jabref.org.sh

* Delete config.yml

* Update gradle.yml

* Set Java to 13.0.3

* Try to really set Java to 13

* Does JDK 1.12 work?

* Uncomment installer related stuff

* Use jpackage

* Fix ? build

* We are using python 3 apparently

* Or not...

* Ah, we are on both at the same time...

* Fix path to jpackage

* Cleanup

* Dont stop trying...

* Debug...

* try to fix path to jpackage

* Add baces

* Set environment variable properly

* Well...

* Dudadud...

* This is fun...

* Set enviornment variable directly

* This is going to be somewhat frusting...

* I feel like I'm learning a lot about shell syntax today

* Spaces are bad?

* C'mon...

* Fix paths?

* This shoud work now...

* Zips are not tars, thats suprising

* Try with url

* Make pretty

* Remove debugging output

* Rename gradle.yml to depoyment.yml

* Rename depoyment.yml to deployment.yml

* Update build.gradle

* Fix build

* Does uploading works now?

* Improve installer for windows

* Remove install4j and shadowjar from gradle

* Change hostname from build-upload to build

* Does scp work?

* Deploy to branch folder

* Archive portable version before upload

* Put in distribution folder

* Beautify on linux and mac

* Update build.gradle

* Update build.gradle

* Fix folder structure in archive

* Try to fix dev version string in about dialog

* Remove oss.soatype.org since this is constantly failing lately

* Add dev switch
@tobiasdiez tobiasdiez mentioned this pull request Oct 7, 2019
6 tasks
@tobiasdiez tobiasdiez closed this Oct 7, 2019
koppor pushed a commit that referenced this pull request Mar 29, 2021
e1acabe Upload Styles (#5351)
d9cbf08 Update and rename journal-of-eta-maritime-science.csl to dependent/journal-of-eta-maritime-science.csl (#5353)
988ecca Update clinical-and-translational-immunology.csl (#5348)
1691078 Update molecular-plant-pathology.csl (#5349)
932a5bf Create neurospine.csl (#5334)
d663ffc Update sylwan.csl (#5341)
b7be05d Update pakistan-journal-of-agricultural-sciences.csl (#5343)
d742832 Please rename to Tijdschrift-voor-geneeskunde-en-gezondheidszorg (#5344)
6c6be4d Update et-al settings for journal-of-the-american-society-of-nephrology.csl (#5333)
0263204 Correct citation format of numeric AOSIS styles (#5335)
e4cd348 Create the-horticulture-journal.csl (#5327)
5804a6f Add AOSIS dependents (#5332)
2b4510b Create natura-croatia.csl (#5328)
03c6789 Create groundwater.csl (#5329)
e08fa09 Create hystrix-the-italian-journal-of-mammalogy.csl (#5330)
1d730aa update page-range-format for Anglia (#5331)
9bb8724 Sort American Physiological Society citation style according to updated author instructions (#5305)
a8b53ca Create african-online-scientific-information-systems-vancouver.csl (#5326)
c7d8f90 Update yozgat-bozok-universitesi-fen-bilimleri-enstitusu.csl (#5319)
87dc0eb Update and rename tijdschrift-voor-geneeskunde.csl to tijdschrift-voo… (#5325)
89e07b0 Create university-of-gothenburg-apa7-swedish-legislations (#5316)
4582cb6 Create chinese-law-journals.csl (#5314)
6412083 Create stellenbosch-law-review.csl (#5322)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: e1acabe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: snap When JabRef is run as a snap on linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants