Conversion of preferences/exportsorting, import, maintable and entryeditor to mvvm

[calixtus]

follow-up to #5033

This PR ha grown pretty huge too, although there is nothing really complicated in it. The four very simple tabs are converted and I included some suggestions about templates/generics and icons @tobiasdiez made in #5185 comment and in #5265.

The SaveOrderConfigDisplay had to be refactored, as there were some bugs: It did not want to set the values after resetting the preferences and it could not load the fields-class (crazy java9-module-stuff), so I also had to change some exports in the modules-info. There I also included some changes out of the gitter-discussion.

I already got some ideas how to resort all the preferences and options in the options-menu, One could change the ListView on the sidePane to a TreeView and start thinning each tab into small preferenceTabs. The help buttons could also be somehow adjusted for each tab at the same position. (maybe somewhere to the right of the title)

I guess there are some things to be discussed or corected in this PR, so im looking forward for your comments.

---

• Change in CHANGELOG.md described
• Tests created for changes
• Manually tested changed features in running JabRef
• Screenshots added in PR description (for bigger UI changes)
• Ensured that the git commit message is a good one
• Check documentation status (Issue created for outdated help page at help.jabref.org?)

[calixtus]

I accidentally pushed some changes I temporarily made to the checkstyle.xml, since the dtd does not exist on the puppycrawl-server. Should I remove them again?

[Siedlerchr]

Could you please add a comment why this is necessary?

[calixtus]

The FXThread or setValues()?
This is something I forgot to put in a BackgroundTask, @tobiasdiez asked to lazy-load the prefs, I did not have time to look deeper into it.

[calixtus]

Is this a bad idea?
BackgroundTask.wrap(() -> DefaultTaskExecutor.runInJavaFXThread(() -> viewModel.setValues())).executeWith(Globals.TASK_EXECUTOR);

I know, that is not lazy loading of the preference values at all. But lazy loading would mean, there need to be some more precautions and checks, like in the store-method of the tabs, that they wont store empty prefs. Just wanted to hear your thoughts before I start refactoring something, that could be rejected in the end.

[tobiasdiez]

Oh, I formulated that in a quite misleading way. What I meant is that tab.setValues should only be called when tab gets the focus - and not when the preference dialog is loaded. I was hoping to improve the loading time of the dialog in that way. But this kind of lazy loading probably needs a bit of refactoring because you don't want to override the users temporary changes when he switches between tabs. You can leave this also for another PR.

[Siedlerchr]

I accidentally pushed some changes I temporarily made to the checkstyle.xml, since the dtd does not exist on the puppycrawl-server. Should I remove them again?

No problem I guess.

In general code looks good, I did not find anything big. Please test if scroll bars are automatically shown when you resize the tabs or when you have a small screen so that all is still visible.

The java 9 module stuff is indeed crazy. I did not knew that it's required in the same project. Always thought it's for external visibility

[tobiasdiez]

Thanks! I have to disappoint you as my remarks are only minor - so your thesis will be happy to get your full attention tomorrow ;-) (or are already finished?).

[tobiasdiez]

Yes, just leave these changes...they are so minimal that they don't justify the overhead of a new PR.

[tobiasdiez]

Oh, I formulated that in a quite misleading way. What I meant is that tab.setValues should only be called when tab gets the focus - and not when the preference dialog is loaded. I was hoping to improve the loading time of the dialog in that way. But this kind of lazy loading probably needs a bit of refactoring because you don't want to override the users temporary changes when he switches between tabs. You can leave this also for another PR.

[calixtus]

Thanks! I have to disappoint you as my remarks are only minor - so your thesis will be happy to get your full attention tomorrow ;-) (or are already finished?).

😭
not done yet, but I want to send the professor my current (and hopefully my last) draft tomorrow.

[calixtus]

In general code looks good, I did not find anything big. Please test if scroll bars are automatically shown when you resize the tabs or when you have a small screen so that all is still visible.

The scrollbars show up in testing automatically, but only to a certain size (About 600 pixels in width of the preferences dialog. Scenic view does not seem to work with a gradle run on my machine currently). Below that, the scrollbar is being eaten by the dialog width.

I created the fxml very quickly with a fixed width of 650 pixels for simplicity, as I had no patience yet to make everything scalable. But I think this could be easily done after everything is converted to the mvvm-pattern just inside the fxmls.

This is quite a todo list, growing and growing: 😀

1. convert appereance-tab and bibtexkeypattern-tab to mvvm
2. rework display of group, file, uri and eprint-column in the maintable
3. rework specialfields for entryeditor (maybe a compact controlelement with the symbols similar to the display in the table columns)
4. rework the preferences-order (create new abstraction-layers for JabRefPreferences 5047 comment )

[Siedlerchr]

I am merging this now! Thanks again for your continouos contribution! 👍 We really appreciate that!

I would say we should first focus on finishing the prefs tabs stuff. Making it look "nice" is another not so important task atm.