Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert PreferenceDialog to MVVM #5033

Merged
merged 23 commits into from
Jun 14, 2019
Merged

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Jun 5, 2019

One of the last missing things in #3861 is the conversion of the PreferenceDialog and some of its tabs to MVVM. I understood that in the future JabRefPreference probably need Properties, to make them bindable. But for now I think this goes beyond this PR.

It works as expected. I took the liberty, to add a split-pane between the conents and the tabList to enable the user to change the width between them, so this PR is not just about refactoring the Dialog. ;-)

This is very early shot on this matter. I don't know if you think it's worth moving on with this and to look also into the tabs.

preferenceDialog

Tabs to convert to MVVM

  • General
  • File

The following conversions will be done in other PRs, as this one would grow too large.

After conversion of the tabs

  • Code cleanup, simplification, refactoring
  • Reordering the preferences

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr
Copy link
Member

Wow! Thanks for your take on this!
This is really a great thing.

Ideally for each tab you would have an fxml marked with root, so it's a custom component. (you have a similar concept in modern web front-end stuff)
For the default export options I already did that because they are reused in the library properties dialog.

@calixtus
Copy link
Member Author

calixtus commented Jun 5, 2019

For the default export options I already did that because they are reused in the library properties dialog.

Oh yeah, I see that now. This is great, this is almost all the work. I can almost just copy'n'paste yours. 😆

@calixtus
Copy link
Member Author

calixtus commented Jun 6, 2019

I made some visual improvements and converted the GeneralTab to MVVM, still everything WIP, but you can see, where the road goes. I encountered a problem, I'd like to ask to help with:
I wasn't able to apply l10n on the controls on the pane - which is why travis is currently failing - but on the large headings, which are basically labels too... Very strange. Do you have an idea?

GeneralsTab

@calixtus
Copy link
Member Author

calixtus commented Jun 6, 2019

The basic workflow is now understood, the other tabs should't take too long, but I do not have much spare time the next days, so it could take some days I can continue to commit and do some cleanups. In the meantime, could you take a quick trivial look into the code, if I did something utterly wrong, so I don't repeat it?

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This looks really good! Well done.

It is nice that you want to continue reworking the other tabs (no hurry!). Feel free to also move preference options between tabs or introduce new tabs. The current layout is sometimes so confusing...
If you want we can also merge this PR (after a small revision) and you can do the rework of the other tabs in new PRs. I fear otherwise this PR gets to large.

@Siedlerchr
Copy link
Member

Thank you very much! I think we should follow the suggestion by @tobiasdiez and merge this asap and you or others can then create the fxml and logic for new tabs

@calixtus
Copy link
Member Author

calixtus commented Jun 7, 2019

ok, i will get this ready to merge asap, but there really need to be some cleanups after converting the last one of the tabs.

@calixtus
Copy link
Member Author

calixtus commented Jun 8, 2019

I added the FileTab, beacause i already started with it, before we were talking about merging this asap, but should be soon ready. Now I am to tired. Should be ready saturday night.

@calixtus
Copy link
Member Author

calixtus commented Jun 8, 2019

Sorry, I was not able to present a solution including the Validator. I got them somehow working, but there is still an big issue: Somehow, the Validator does not seem to be updated after something was typed in the textfield. The StringProperty keeps somehow the old input if i dont disable and reenable it. I will have another try tomorrow.

@@ -2118,4 +2118,24 @@ public void setActivePushToApplication(PushToApplication application, PushToAppl
manager.updateApplicationAction();
}
}

public NewLineSeparator getNewLineSeparator() {
String newline = get(JabRefPreferences.NEWLINE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a method in the OS class which already returns the system line separator

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into the code, I just realized another mistake I made.
In this mentioned case: OS.NEWLINE returns the newline-seperator of the user system. This method here concerns the stored newline-seperator in the preferences, the user can change just as she likes.

Copy link
Member Author

@calixtus calixtus Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a moment, now I think I understand your concern: The variable OS.NEWLINE, which normally returns the system-newline-separator is being overwritten by the method setNewLineSeparator. My question: Is this not a bug? Should the OS.NEWLINE return the user-system newLineSeparator or the one stored in the preferences? I'm a little bit confused.

I guess, as everywhere else OS.NEWLINE is used, JabRef stores in this string the actual var, which is easy to use with other strings. On the other hand, I think in the preferencesDialog, should work with the Globals.prefs directly, as OS.NEWLINE is a helper variable, which is created by initialization out of Globals.prefs, but is never stored.

I created the NewLineSeparator.class in the first place to ease up the work with the ComboBox and to get the if-else-construct out of setValue and storeValue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code is correct the way it is right now. The OS.NEWLINE returns the os-default newline character except if the user chooses to overwrite it in the preferences. It's a bit confusing (especially since OS.NEWLINE suggests that it is a constant).

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, thanks a lot. The code looks really good and 👍 for merging from my side.

@calixtus
Copy link
Member Author

Fixed two little things and injected dialogService. Ready again.

if (preferences.getBoolean(JabRefPreferences.BIBLATEX_DEFAULT_MODE)) {
selectedBiblatexModeProperty.setValue(BibDatabaseMode.BIBLATEX);
} else {
selectedBiblatexModeProperty.setValue(BibDatabaseMode.BIBLATEX);
Copy link
Member

@LinusDietz LinusDietz Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug SPOTTED! (fix incoming #5211 !) @calixtus

github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to RamonG92/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to dimitra-karadima/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to Xuanxuan-Zou/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to felixbohnacker/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to eetian/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to dextep/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (#5040)
58d65fd Create cureus.csl (#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (#5041)
39a3fbb Create finance-and-society.csl (#5043)
cf39e19 Create canadian-biosystems-engineering-journal (#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (#5024)
776002d create new independent style for deutsches-arzteblatt.csl (#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (#5036)
13e0a0b Update iso690-full-note-cs.csl (#5033)
3af2034 Create acta-medica-peruana.csl (#5037)
dcbe494 Create historia-scribere.csl (#5038)
2174323 make addiction-biology.csl an AMA dependent (#5028)
b01aea8 Update ios-press-books.csl (#5030)
ae6d0e2 add doi for article-journal for ASA.csl (#5031)
d537025 Create organised-sound.csl (#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (#5026)
3dc5157 Update amerindia.csl (#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to graffaner/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
github-actions bot pushed a commit to joe9111/jabref that referenced this pull request Oct 1, 2020
6fab78b Create physiologia-plantarum.csl (JabRef#5040)
58d65fd Create cureus.csl (JabRef#5048)
5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042)
e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041)
39a3fbb Create finance-and-society.csl (JabRef#5043)
cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046)
3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024)
776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035)
b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036)
13e0a0b Update iso690-full-note-cs.csl (JabRef#5033)
3af2034 Create acta-medica-peruana.csl (JabRef#5037)
dcbe494 Create historia-scribere.csl (JabRef#5038)
2174323 make addiction-biology.csl an AMA dependent (JabRef#5028)
b01aea8 Update ios-press-books.csl (JabRef#5030)
ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031)
d537025 Create organised-sound.csl (JabRef#5032)
ef4d15e Create independent EMBO Press
640fdac Create forensic-anthropology.csl (JabRef#5026)
3dc5157 Update amerindia.csl (JabRef#5027)
fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029)
facc3f9 Aging &Disease: remove unused macros
661e9fa Sort aging and disease by cite number
8746709 show issue numbers in springer basic author-date style (JabRef#4854)
c358b17 Update Journal of Universal Computer Science

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 6fab78b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants