Select push app in preferences #5024

calixtus · 2019-06-02T22:25:26Z

As asked by @tobiasdiez, here is my alternative proposal, this closes #4991 by merging.
fixes #674 closes #3942 and closes #4368

This branch is build up on the other branch, including the other commits, this time by intention.
I hope you like it. Have a good night!

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

calixtus · 2019-06-02T22:59:35Z

What I really hate is the hardcoding of applicationNames in PushToApplicationSettings.class. But before there was only some cryptic numbering scheme, depending on the order, the push-applications were created in the first place. At least, it's a little bit more readable. Yet I saw no other way without a larger refactoring of this code.

Ready to review

calixtus · 2019-06-04T09:06:50Z

I added some eye-candy, you will be charmed. ;-)

Siedlerchr · 2019-06-04T09:38:25Z

Looks good to me!

Siedlerchr

LGTM, prefer this solution over the other

tobiasdiez

That looks indeed really nice. Thanks! I have a few minor remarks concerning the code. If you fix these, then we can merge and finally close this long-open book about push to applications ;-).

src/main/java/org/jabref/gui/JabRefFrame.java

src/main/java/org/jabref/gui/preferences/ExternalTab.java

src/main/java/org/jabref/gui/push/PushToApplicationAction.java

tobiasdiez · 2019-06-04T10:08:12Z

src/main/java/org/jabref/gui/push/PushToApplicationSettings.java

-    public GridPane getJFXSettingPane(int n) {
-        switch (n) {
-            case 0:
+    public GridPane getJFXSettingPane(String applicationName) {


What about tests of the form application is instanceof(...), then you don't need to work with "magic" strings.

I found it very hard to understand the code in PushToApplicationSettings, so i took the liberty, to refactor this class a little bit.

src/main/java/org/jabref/gui/push/PushToApplicationsManager.java

calixtus · 2019-06-04T16:42:17Z

Ok, should be ready again. There are still a lot of things, that could be done, e.g. refactoring of the Preferences-Dialog and changing the single tabs to MVVC, but I don't want to interfere with the other rework towards 5.0 and the fate of swing.

Siedlerchr · 2019-06-04T18:01:24Z

Looks good, please check if you can select the push to application multiple times after each other without closing the prefs dialog
Select lyx and then again select Texstudio for example.
If it works all is good

calixtus · 2019-06-04T19:54:19Z

Works fine. At least if I understood you right. I hope so.

tobiasdiez · 2019-06-04T21:44:09Z

Looks very good to me now. Thanks again!

calixtus · 2019-06-04T22:09:37Z

You are welcome. This was fun - again! Let's push JabRaf forward towards 5.0. ;-)

6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b

6fab78b Create physiologia-plantarum.csl (#5040) 58d65fd Create cureus.csl (#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (#5041) 39a3fbb Create finance-and-society.csl (#5043) cf39e19 Create canadian-biosystems-engineering-journal (#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (#5024) 776002d create new independent style for deutsches-arzteblatt.csl (#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (#5036) 13e0a0b Update iso690-full-note-cs.csl (#5033) 3af2034 Create acta-medica-peruana.csl (#5037) dcbe494 Create historia-scribere.csl (#5038) 2174323 make addiction-biology.csl an AMA dependent (#5028) b01aea8 Update ios-press-books.csl (#5030) ae6d0e2 add doi for article-journal for ASA.csl (#5031) d537025 Create organised-sound.csl (#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (#5026) 3dc5157 Update amerindia.csl (#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b

6fab78b Create physiologia-plantarum.csl (JabRef#5040) 58d65fd Create cureus.csl (JabRef#5048) 5b68591 Create institut-de-recherches-archeologiques-preventives.csl (JabRef#5042) e238ca2 Create method-and-theory-in-the-study-of-religion.csl (JabRef#5041) 39a3fbb Create finance-and-society.csl (JabRef#5043) cf39e19 Create canadian-biosystems-engineering-journal (JabRef#5046) 3d12b8f Create cardiff-university-biosi-and-carbs-only-harvard.csl (JabRef#5024) 776002d create new independent style for deutsches-arzteblatt.csl (JabRef#5035) b167cd6 Create revista-peruana-de-medicina-experimental-y-salud-publica.csl (JabRef#5036) 13e0a0b Update iso690-full-note-cs.csl (JabRef#5033) 3af2034 Create acta-medica-peruana.csl (JabRef#5037) dcbe494 Create historia-scribere.csl (JabRef#5038) 2174323 make addiction-biology.csl an AMA dependent (JabRef#5028) b01aea8 Update ios-press-books.csl (JabRef#5030) ae6d0e2 add doi for article-journal for ASA.csl (JabRef#5031) d537025 Create organised-sound.csl (JabRef#5032) ef4d15e Create independent EMBO Press 640fdac Create forensic-anthropology.csl (JabRef#5026) 3dc5157 Update amerindia.csl (JabRef#5027) fca38a2 Create journal-of-the-botanical-research-institute-of-texas.csl (JabRef#5029) facc3f9 Aging &Disease: remove unused macros 661e9fa Sort aging and disease by cite number 8746709 show issue numbers in springer basic author-date style (JabRef#4854) c358b17 Update Journal of Universal Computer Science git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6fab78b

calixtus added 19 commits May 28, 2019 15:37

Added Submenu to change external push-app

2e6896b

Rewording, Respacing and Optimizing

f420082

Rewording Confusing PushApplications to PushToApplicationsManager

1883f6f

Refactoring and unifying PtAAction with ToolbarButton

d0aa24c

Refactor simplified

6fa926f

Reword l10n

f48a9d4

Refactor for checks

746e025

Added eye-candy

5d6a7cf

Added eye-candy

a8b6489

Changelog

186f9bc

whitespaces

ec5f96b

Merge remote-tracking branch 'upstream/master' into menu_select_push_app

91e4393

Rewording, Sorting, Simplifying

2ce9d37

Whitespace

e66586e

Rewording, Sorting

a91455d

Refactor var-declaration

eddbe0a

Removed Submenu and Added Preferences Setting

fadd6ce

Fixed compiletime-error

96e4b6f

Added App-settings-button

734e8c9

calixtus mentioned this pull request Jun 2, 2019

Submenu to select push-application #4991

Closed

6 tasks

Changelog

fd18502

calixtus changed the title ~~Pref select push app~~ Select push app in preferences Jun 2, 2019

Whitespaces and superflous

6ae31aa

calixtus added 5 commits June 3, 2019 01:26

Revert persistent actionInformation

26a1c93

Merge branch 'menu_select_push_app' into pref_select_push_app

4084701

Removed superfluous declaration

2f1637a

Merge branch 'menu_select_push_app' into pref_select_push_app

3fa27df

Added eyecandy

4b0862c

Refactor so simplify

435a87f

Siedlerchr approved these changes Jun 4, 2019

View reviewed changes

tobiasdiez requested changes Jun 4, 2019

View reviewed changes

calixtus added 3 commits June 4, 2019 14:03

Refactor for some minor requests

4406e1a

Refactor of PushToApplicationSettings

89ac2fe

Checkstyle

dbed029

tobiasdiez merged commit 9a5b7d1 into JabRef:master Jun 4, 2019

This was referenced Jun 4, 2019

[WIP] Add External Application Selection to Preferences #3942

Closed

WIP Default External Application Push Function #4368

Closed

calixtus deleted the pref_select_push_app branch June 4, 2019 22:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Select push app in preferences #5024

Select push app in preferences #5024

calixtus commented Jun 2, 2019

calixtus commented Jun 2, 2019 •

edited

Loading

calixtus commented Jun 4, 2019

Siedlerchr commented Jun 4, 2019

Siedlerchr left a comment

tobiasdiez left a comment

tobiasdiez Jun 4, 2019

calixtus Jun 4, 2019

calixtus commented Jun 4, 2019 •

edited

Loading

Siedlerchr commented Jun 4, 2019

calixtus commented Jun 4, 2019 via email •

edited

Loading

tobiasdiez commented Jun 4, 2019

calixtus commented Jun 4, 2019

Select push app in preferences #5024

Select push app in preferences #5024

Conversation

calixtus commented Jun 2, 2019

calixtus commented Jun 2, 2019 • edited Loading

calixtus commented Jun 4, 2019

Siedlerchr commented Jun 4, 2019

Siedlerchr left a comment

Choose a reason for hiding this comment

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Jun 4, 2019

Choose a reason for hiding this comment

calixtus Jun 4, 2019

Choose a reason for hiding this comment

calixtus commented Jun 4, 2019 • edited Loading

Siedlerchr commented Jun 4, 2019

calixtus commented Jun 4, 2019 via email • edited Loading

tobiasdiez commented Jun 4, 2019

calixtus commented Jun 4, 2019

calixtus commented Jun 2, 2019 •

edited

Loading

calixtus commented Jun 4, 2019 •

edited

Loading

calixtus commented Jun 4, 2019 via email •

edited

Loading