Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF files won't open anymore #5253

Closed
1 task done
j0hannes opened this issue Aug 28, 2019 · 50 comments
Closed
1 task done

PDF files won't open anymore #5253

j0hannes opened this issue Aug 28, 2019 · 50 comments
Labels
os: linux status: waiting-for-feedback The submitter or other users need to provide more information about the issue

Comments

@j0hannes
Copy link

JabRef version 5.0-dev

Clicking on a document icon used to open the associated PDF. Now, the PDF viewer opens and closes immediately. No error is logged.

Steps to reproduce the behavior:

  1. Click on a document icon
@Siedlerchr
Copy link
Member

Cannot reproduce this under Windows 10. PDF opens fine. Sure the path is correct?

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Aug 28, 2019
@j0hannes
Copy link
Author

I have the configured a "main file directory". The "file" entries are just bare file names. If I go to that directory and call the PDF viewer with one of the file names, it will open.

@stefan-kolb
Copy link
Member

Please check external programs tab in preferences where the paths to PDF viewer etc. are set.

@j0hannes
Copy link
Author

There are two options under "Open PDF", Adobe Acrobat Reader and Sumatra Reader. None of them is checked. When I click on a document, I see a new instance of Okular, which is the default application that has worked until now. After a couple of seconds this instance disappears; no errors are logged.

@AEgit
Copy link

AEgit commented Sep 8, 2019

JabRef 5.0-dev
Linux 5.0.0-27-generic amd64
Java 1.8.0_222

Cannot confirm this issue. What I do note with the snap version I am using, however, is that every time I want to access a PDF file, I have to accept the following message:

Allow opening file?

Allow snap "jabref" to open file "/path/to/my/pdf/my.pdf"?

This dialogue will close automatically after 5 minutes of inactivity.

My PDFs are stored on a NTFS formatted drive (I am running Linux and Windows in a dual-boot configuration) which is mounted to /media/myuser. To access that folder using the snap version of JabRef it was necessary to use the removable-media option, i. e. sudo snap connect jabref:removable-media. This allows JabRef to access the drive/folder. However, the message reported above will still appear every time JabRef tries to open an associated file stored on the NTFS formatted drive. Is there a way so that I only have to accept this message once? Is this even a JabRef issue or is this something related to the general implementation of snap?
See also:
https://forum.snapcraft.io/t/always-allow-opening-file/5646/2
https://askubuntu.com/questions/1051207/snap-how-to-grant-permament-permission-to-read-folder

@j0hannes
Copy link
Author

j0hannes commented Sep 8, 2019

With the most recent dev snapshot (JabRef 5.0-dev--snapshot--2019-09-05--master--99a0a7a8d), PDF files open instantaneously. Have there been any recent changes on that code?

I think, we may close the ticket.

@j0hannes j0hannes closed this as completed Sep 8, 2019
@amontero90
Copy link

This behaviour is still present in the with the deb package in

https://builds.jabref.org/master/jabref_5.0.0-1_amd64.deb

Built in 2019-10-21

@j0hannes
Copy link
Author

The same version from sources works for me.

@amontero90
Copy link

And by sources you mean.. exactly the same link I provide above?

I just tested again on a fresh installation of Kubuntu 19.10. The behaviour is exactly the one that j0hannes described in the first comment. I can also reproduce what AEgit described with the snap package even though my files are stored in the same unit as JabRef.

@j0hannes
Copy link
Author

These are the sources: https://builds.jabref.org/master/JabRef-portable_linux.tar.gz

Shouldn't make a difference to what you find in the deb package, though.

@amontero90
Copy link

I should have said in my previous comment. The same behaviour with the sources you mentioned.

@tobiasdiez tobiasdiez reopened this Oct 23, 2019
@amontero90
Copy link

Update: seems to be a permissions problem. The path for the application in my system is /opt/jabref/bin/JabRef. However, if I run sudo /opt/jabref/bin/JabRef it is possible to open PDF files as usual. This might offer some workarounds.

@j0hannes
Copy link
Author

To my surprise I couldn't open PDF files on my other machine, which is set up identically to the one where it worked after upgrading. Ther error message was kf5.kio.widgets: Malformed URL: "".

After changing the standard library path for PDFs from a symlink to the real path, opening those PDFs worked again. It seems as if symlinks are problematic for JabRef or one of its components. Running it as root might circumvent the problem that symlinks are causing - just a wild guess.

@Siedlerchr
Copy link
Member

Thanks for the hint with symlinks . There might be an option which needs to be passed to the path methods
and also the hint for snaps.

@amontero90
Copy link

@j0hannes... I think they are different (although possibly related) errors. The one that you mention seems to be a path issue. A very similar error occurs if your links (the links that JabRef uses to the files) are broken; in particular, when the file path is not well configured. The links in my situation are well configured, since I can open pdf files without changing them. Anyways, thanks for the input.

@Krzmbrzl
Copy link

I ran into (seemingly) the same issue on KDE Neon. If I try to open a PDF, I only see the Okular icon jumping around my cursor but then it vanishes without Okular starting.

I also found out that if I have Okular open already, I can open PDFs without problem (they appear in new tabs in the same Okular instance as this is the way I have Okular configured).

Info from JabRef's about-page:

JabRef 5.0.0-dev--2019-10-25----681d6aa6f
Linux 5.0.0-32-generic amd64 
Java 12.0.2

@t-morales
Copy link
Contributor

I have the same problem.
I downloaded the latest snapshopt of Jabref and I cannot get to open any pdf.
I tried with okular open as described by Krzmbrzl but the pdf not opening for me
I tried to run jabref with sudo. Now, when I click on the pdf icon, the pdf file opens but with gimp.

Any ideas on how to resolve the problem?

@Siedlerchr
Copy link
Member

Siedlerchr commented Jan 3, 2020

Hmm. As far as I remember JabRef simply uses xdg-open or passes the file path to xdg open

@Krzmbrzl
Copy link

Krzmbrzl commented Jan 3, 2020

@t-morales did you try using xdg-open to open the PDF from the command-line?

@t-morales
Copy link
Contributor

I tried with xdg-open:

  • Running with normal user it opens pdf correctly
  • Running as sudo or root, I have seen that it was not correctly configured to okular, so I have set now okular as default for root
  • Now, when I run JabRef with sudo, pdf opens correctly with okular
  • When I run JabRef as normal user, still the same behavior, the pdf does not open

@t-morales
Copy link
Contributor

Hi:
Anyone has any more information on this topic?
Up to now, the only workaround I found is to run JabRef with sudo.

@Siedlerchr
Copy link
Member

JabRef's code is to call xdg open or a configured application. https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/desktop/os/Linux.java

Could you please specify if it makes any difference from where you open the pdf?
e.g. from the maintable or from the general tab

@t-morales
Copy link
Contributor

It makes no difference. Using the main table or the general tab does not open pdf file.
I do not obtain any error message or information on what the problem is.
The only thing that works for me is to run jabref with sudo command. Then, clicking on the pdf icon will open it.

@Siedlerchr
Copy link
Member

I tested it today in my Ubuntu VM Ubuntu 18.04 with Xfce and Atril Document Viewer and it works fine.

JabRef 5.0-beta.354--2020-01-18--2612e22
Linux 4.15.0-62-generic amd64
Java 13.0.2

JabRef is installed under /opt/jabref from the deb package.
I'm not a LInux expert. @LyzardKing Any idea on why xdg open apparently requires sudo?

@Krzmbrzl
Copy link

Does JabRef somehow interact with the system via its own pseudo user? If that'd be the case, then maybe the problem is that xdg-open doesn't work with that specific user account...

@Siedlerchr
Copy link
Member

Please be aware that the java Runtime.exec() is not a shell! It's much more limited:
https://stackoverflow.com/a/31776547

So I guess this is some okular specific issue?
I could only add some code to display results from error or output stream in JabRef. maybe this gets some insights

@Krzmbrzl
Copy link

Did someone try to write a small standalone Java application that uses exec and xdg-opento open a PDF via Okular?

@LyzardKing
Copy link
Collaborator

LyzardKing commented Jan 20, 2020

In ubuntu-mate I tried running a Java REPL (JShell) with the following command:
Runtime.getRuntime().exec("xdg-open <path-to-pdf>")
And it succesfully opened okular (the default pdf viewer in my system settings).

@t-morales
Copy link
Contributor

I am not a java expert, but it seems that this is java related. I have tried the following program in java:

import java.io.BufferedReader;
import java.io.InputStreamReader;

public class testprog {
    public static void main(String args[]) {
        String s;
        Process p;
        try {
            p = Runtime.getRuntime().exec("xdg-open <path-to-pdf>");
        } catch (Exception e) {}
    }
}

When the default application is set as okular, the pdf does not open.
When I switch to atril, it works.

@t-morales
Copy link
Contributor

If anyone knows where or how I could get more information on this topic I would be grateful.

@tobiasdiez
Copy link
Member

tobiasdiez commented Jan 20, 2020

You can try to see if there is an error message using

    BufferedReader in = new BufferedReader(new InputStreamReader(p.getErrorStream()));
    String line;
    while ((line = in.readLine()) != null) {
        System.out.println(line);
    }
    p.waitFor();
    System.out.println("ok!");

    in.close();

https://stackoverflow.com/a/8150065/873661

The second part of the answer (using ProcessBuilder) also might be worth a try.

@LyzardKing
Copy link
Collaborator

@t-morales
That simple program works on my system, so I don't think it's a java issue.

@t-morales
Copy link
Contributor

t-morales commented Jan 20, 2020

So, I think that I am close to know what is happening. For some reason, there is an error message that is obtained:
discarding "Send SMS via KDE Connect." ("ShareUrl")
But now, using the extra commands given by @tobiasdiez, the pdf opens with okular.
What I mean is that the code

import java.io.BufferedReader;
import java.io.InputStreamReader;

public class testprog {
    public static void main(String args[]) {
        String s;
        Process p;
        try {
            p = Runtime.getRuntime().exec("xdg-open <path-to-pdf>");
            BufferedReader in = new BufferedReader(new InputStreamReader(p.getErrorStream()));
            String line;
            while ((line = in.readLine()) != null) {
                System.out.println(line);
            }
	    p.waitFor();
	    System.out.println("ok!");

    in.close();
        } catch (Exception e) {}
    }
}

will open the pdf.

My guess is that in the previous code an error occurs which is not handled and then okular is closed, while this code is treating correctly the error or warning messages. If that makes sense.

@Krzmbrzl
Copy link

Krzmbrzl commented Jan 20, 2020

Would be kinda weird, but I guess it wouldn't be unheard of xD
You mentioning KDE brings to my mind that maybe this is a KDE specific bug as I am using KDE as well. Did someone encounter this bug with a different desktop environment?

@t-morales
Copy link
Contributor

Thank you so much for your help. I now have a modified version of JabRef that works!

What I did is to edit the file src/main/java/org/jabref/gui/desktop/os/Linux.java and replace

Runtime.getRuntime().exec(cmdArray);
by

Process p;
p = Runtime.getRuntime().exec(cmdArray);
BufferedReader in = new BufferedReader(new InputStreamReader(p.getErrorStream()));
String line;
line = in.readLine();

Probably not a pretty solution, but as I said I am not familiarized with java.
Now the pdf files open correctly with okular.

@Siedlerchr
Copy link
Member

@t-morales Glad that it works. It would be really helpful for all others, if you could open a Pull Request with your changes. see Contributing for some details, e.g. just create a fork and a branch.

t-morales added a commit to t-morales/jabref that referenced this issue Jan 20, 2020
@t-morales
Copy link
Contributor

OK, I hope I did it correctly: #5855
Nevertheless, it would be great if someone with better understanding took a look at the proposed solution. It was more or less a trial and error solution.

t-morales added a commit to t-morales/jabref that referenced this issue Jan 26, 2020
tobiasdiez added a commit that referenced this issue Jan 26, 2020
* Fix opening pdf with okular in linux (#5253)

* Fix opening pdf with okular in linux (#5253) stream ouput to Logger

* Fix checkstyle

Co-authored-by: Tobias Diez <tobiasdiez@gmx.de>
@tobiasdiez
Copy link
Member

Thanks to @t-morales this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

Siedlerchr added a commit that referenced this issue Jan 28, 2020
* upstream/master:
  Bump unirest-java from 3.4.00 to 3.4.01 (#5874)
  Bump junit-vintage-engine from 5.5.2 to 5.6.0 (#5875)
  Bump checkstyle from 8.28 to 8.29 (#5876)
  Bump junit-jupiter from 5.5.2 to 5.6.0 (#5877)
  Bump junit-platform-launcher from 1.5.2 to 1.6.0 (#5878)
  Change \ to /
  Bump byte-buddy-parent from 1.10.6 to 1.10.7 (#5873)
  Fix opening pdf with okular in linux (#5253) (#5855)
@w1th0utnam3
Copy link

Hi, I have essentially the same bug but it still occurs with the latest JabRef snapshot JabRef 5.0-beta.386--2020-01-28--3579d3d. I changed my default PDF reader from Okular to Evince and it still does not open. It just shows that the respective PDF reader is opening in the taskbar and then it just disappears. Running xdg-open ...pdf in a terminal works and opens Okular/Evince. I'm on Kubuntu 19.10, KDE Plasma 5.17.5, KDE Frameworks 5.66.0.

Any ideas what I can try to do to help?

@t-morales
Copy link
Contributor

Hi @w1th0utnam3
Try just the small java code:

import java.io.BufferedReader;
import java.io.InputStreamReader;

public class testprog {
    public static void main(String args[]) {
        String s;
        Process p;
        try {
            p = Runtime.getRuntime().exec("xdg-open <path-to-pdf>");
            BufferedReader in = new BufferedReader(new InputStreamReader(p.getErrorStream()));
            String line;
            while ((line = in.readLine()) != null) {
                System.out.println(line);
            }
	    p.waitFor();
	    System.out.println("ok!");

    in.close();
        } catch (Exception e) {}
    }
}

That gave me more insight on what was not working.

@w1th0utnam3
Copy link

w1th0utnam3 commented Jan 29, 2020

Thanks @t-morales.

  1. It works with Evince as a default pdf viewer and it prints
Icon theme "gnome" not found.
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/16/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/22/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/24/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/32/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/48/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/64/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/128/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/8x8/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/16x16/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/16x16/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/22x22/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/24x24/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/24x24/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/32x32/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/32x32/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/48x48/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/48x48/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/256x256/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/512x512/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/scalable/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/scalable/ui/"
Icon theme "Mint-X" not found.
Icon theme "elementary" not found.
Icon theme "gnome" not found.

(process:15115): Gtk-WARNING **: 10:05:52.266: Locale not supported by C library.
        Using the fallback 'C' locale.
ok!

But I don't think these errors are relevant for the problem.
2. It does not work with Okular. The Java program instantly returns and prints

Icon theme "gnome" not found.
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/16/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/22/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/24/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/32/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/48/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/64/"
Invalid Context= "stock" line for icon theme:  "/usr/share/icons/ubuntu-mono-dark/stock/128/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/8x8/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/16x16/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/16x16/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/22x22/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/24x24/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/24x24/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/32x32/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/32x32/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/48x48/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/48x48/ui/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/256x256/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/512x512/legacy/"
Invalid Context= "Legacy" line for icon theme:  "/usr/share/icons/Adwaita/scalable/legacy/"
Invalid Context= "UI" line for icon theme:  "/usr/share/icons/Adwaita/scalable/ui/"
Icon theme "Mint-X" not found.
Icon theme "elementary" not found.
Icon theme "gnome" not found.
Icon theme "gnome" not found.
ok!

Meanwhile, it shows the same behavior as in JabRef (looks like it is opening but then disappears). But I cannot see any output from Okular in the terminal because the Java program returns without waiting for Okular.

It's a little bit weird that this Java program works with Envince but it does not work in JabRef. As I said, running xdg-open in the terminal works with both viewers.

@t-morales
Copy link
Contributor

For me it worked with okular with that program.
Maybe try to fix all those warnings?
It seems that it cannot find the icons and themes, so I would try to install them to see if that changes anything

@w1th0utnam3
Copy link

w1th0utnam3 commented Jan 29, 2020

Huh, so switching my system icon theme to a standard theme (like Breeze) fixes all problems because then all these warnings/errors disappear. It also works in JabRef then.

I'm using the Candy icons theme from the KDE store. These warnings are caused by many custom icon packs, e.g. see PapirusDevelopmentTeam/papirus-icon-theme#418. Installing the missing icon themes does not really help because installing one theme adds new errors and I got stuck with "Icon theme "gnome-colors-wise" not found." which I couldn't find anywhere to install. I continued by modifying the index.theme file of the icon pack and removed the dependencies on the other themes so I'm just left with the Invalid Context= warnings. But then it still does not work. It seems like Okular won't start from Java when anyhting appears in stderr. So this has to be a bug somewhere, although I'm not sure in which component in this chain specifically.

@w1th0utnam3
Copy link

w1th0utnam3 commented Jan 29, 2020

So I removed some further dependencies/inheritances from the index.theme file of the icon theme and now all warnings are gone and it works from Java/JabRef again. But I still don't get why this prevents Okular from opening. I don't know if it's a bug with Okular, xdg-open or some weirdness of Java's exec.

EDIT: I replaced xdg-open with a direct call to okular and this works again, even with the warnings appearing in the terminal. So it really is related to this cursed combination of okular, xdg-open and Java.

@w1th0utnam3
Copy link

w1th0utnam3 commented Jan 29, 2020

So I found a workaround in Java. Instead of using exec with xdg-open directly it is possible to use Desktop.getDesktop().open(..) to open any file with the standard application:

import java.awt.Desktop;
import java.io.File;

public class testprog {
    public static void main(String args[]) {
        try {
            Desktop.getDesktop().open(new File("<path to pdf>"));
        } catch (Exception e) {}
    }
}

But I'm not sure if using this might not be possible in JabRef due to Java version restrictions.

Siedlerchr added a commit that referenced this issue Jan 30, 2020
* master: (297 commits)
  Replace link to Workspace set-up with new one (#5896)
  Fixes making paths of linked files relative (web urls will not be touched anymore) (#5879)
  Switch to our IntelliJ config (#5881)
  Bump unirest-java from 3.4.00 to 3.4.01 (#5874)
  Bump junit-vintage-engine from 5.5.2 to 5.6.0 (#5875)
  Bump checkstyle from 8.28 to 8.29 (#5876)
  Bump junit-jupiter from 5.5.2 to 5.6.0 (#5877)
  Bump junit-platform-launcher from 1.5.2 to 1.6.0 (#5878)
  Change \ to /
  Bump byte-buddy-parent from 1.10.6 to 1.10.7 (#5873)
  Fix opening pdf with okular in linux (#5253) (#5855)
  Fixed Test
  Refactored constructors, PreferencesService and some minor improvements.
  Remove ampersand escape when writing to bib file (#5869)
  Fix #5862. It was indeed the throttler (at least it is working now for me) (#5868)
  duplicate query parameter removed (#5865)
  New Crowdin translations (#5864)
  Minor refactoring, and changed comment
  Bump antlr4 from 4.7.2 to 4.8-1 (#5852)
  Reintroducing master table index column (#5844)
  ...
Siedlerchr added a commit that referenced this issue Mar 14, 2021
30fb68e Create BJEDIS-ABNT-Number (#5255)
aafb868 Update geochimica-et-cosmochimica-acta.csl (#5321)
60ba25f british-journal-of-anaesthesia.csl: add comma delimiter between non-sequential citations eg. 1 4 7-9 -> 1, 4, 7-9  (#5313)
67e6564 Reindent/reorder (#5318)
c0d2a39 Ruby 3.0.0 (#5309)
76d60ff Update harvard-anglia-ruskin-university.csl (#5310)
bc18ac9 Create journal-for-the-study-of-the-new-testament.csl (#5312)
aff602c Update journal-of-food-protection.csl (#5315)
4503826 Update muscle-and-nerve.csl (#5317)
3bed58e constant redefinition
4d718a0 update documentaiton link
fa99e2f add comma delimiter between succesive numbers
d396f8b Allow privileged testing of PRs (#5307)
43b22c7 Update masarykova-univerzita-pravnicka-fakulta.csl, pravnik.csl, iso690-full-note-cs.csl (#5308)
8a31c1e Update copernicus-publications.csl (#5303)
96760bb Update anabases.csl (#5304)
744de6d removed locale (#5300)
7eb0d60 Update aviation-space-and-environmental-medicine.csl (#5297)
2769970 Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5298)
51e3f4c Update harvard-university-of-bath.csl (#5299)
5fce84f Create cns-spectrums.csl (#5290)
bb8082c Create journal-of-surgical-oncology.csl (#5259)
90c13ae Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5288)
4bab1ad Update early-christianity.csl (#5289)
636ba78 Update tatup-zeitschrift-fur-technikfolgenabschatzung-in-theorie-und-… (#5291)
b7cc511 Create biotechnologia.csl (#5292)
5bab881 Update journal-of-orthopaedic-trauma.csl (#5287)
5943413 Fix locales (#5285)
302bd65 Update universite-du-quebec-a-montreal-departement-dhistoire.csl (#5286)
860ae48 Add Haaga-Helia University of Applied Sciences Harvard style (#5282)
c1c27de  Localize Metropolia style title (#5283)
508da89 Fix presentation for Methods of Information in Medicine (#5284)
53e1d0b Create geschichte-und-gesellschaft.csl (#5216)
d7ed0cb Create universite-de-geneve-departement-de-francais-moderne.csl (#5212)
80c404b Update journal-of-orthopaedic-trauma.csl (#5281)
20c143a Adding publishers' names (#5280)
6e5cd59 Update sodertorns-hogskola-oxford.csl (#5279)
52f2621 dollar-brace
a260294 Create journal-of-microbiology-and-biotechnology.csl (#5277)
1fc979e Create qeios.csl (#5261)
86347b7 GH does this for us -- again, sorry guys
b649589 Create experimental-biology-and-medicine.csl (#5276)
12ae0b1 Revert "tell sheldon about the job state"
bdcae89 tell sheldon about the job state
1240067 Add Vegetation classification and Survey (#5271)
6f398f0 Major update to Gallia.csl (#5269)
2a74b2c Update filters.yaml (#5273)
20046d2 Update spec_helper.rb (#5272)
2ee0dd8 Create the-sociological-review.csl (#5260)
5b8d09c move filters to inert file to pacify Sheldon (#5268)
e5f3315 Localize more language descriptors in style titles (#5270)
bfd2942 Localize more language descriptors in style titles (#5267)
35e276f Fix variable used for the label after indication of number of pages (#5240)
60f6371 Create Universidade-do-Estado-do-Rio-de-Janeiro.csl (#5247)
d8cc2ae Create the-journal-of-the-acoustical-society-of-america-numeric.csl (#5256)
92259c1 Create journal-of-financial-and-quantitative-analysis.csl (#5264)
6ba8aab Create journal-of-vestibular-research.csl (#5258)
0c88f41 Update european-journal-of-international-law.csl (#5265)
cff5abc Put language descriptor within parentheses
4a62709 Update monash-university-harvard.csl (#5253)
64fd1aa Localize more language descriptors in style titles (#5262)
f6519cb Localize more language descriptors in style titles (#5257)
170ccae tiny fixes for universitat-basel-iberoromanistik.csl (#5254)
b7284c9 Localize more language descriptors in style titles (#5252)
f4ef858 Add "Baishideng Publishing Group" dependents (#5251)
266e7c3 Make world-journal-of-hepatology.csl to bpg.csl parent (#5243)
9129098 fix small formatting issues for mclc.csl (#5229)
5d9560b Create crispr-journal.csl (#5249)
a217299 Change "Czech" to "Čeština" in titles (#5248)
4fef39a Create journal-of-open-research-software.csl (#5245)
2bff1a6 Change "Dutch" to "Nederlands" in titles (#5242)
f28da34 Update spec_helper.rb (#5246)
e0e977c Move content from wiki pages to markdown files (#5194)
018304c Update universite-de-montreal-apa.csl (#5239)
3b83e5c Create sodertorns-hogskola-oxford.csl (#5234)
1335378 Stop notifying 8827 port on Zotero servers (#5237)
f079b2a Update author-year disambiguation (#5238)
60bb0c9 Update technische-universitat-dresden-medizin.csl (#5236)
e374657 Create Leidraad voor juridische auteurs 2019 (Dutch) (#5223)
0450d89 Add new style for U of Mannheim, Germanistische Linguistik (#5228)
81f0689 Create health-sports-rehabilitation-medicine.csl (#5233)
c152a44 Update Gemfile.lock (#5235)
748e1eb Update geochimica-et-cosmochimica-acta.csl (#5231)
06b9ce8 Update zeitschrift-fur-theologie-und-philosophie.csl (#5230)
e747cb1 haute-ecole-de-gestion-de-geneve: Make polyglot & et al changes
4cfedb7 Create universite-de-sherbrooke-histoire.csl (#5210)
a96a61e Update journal-of-glaciology.csl (#5222)
c6a94c9 Add Journal of Human Rights (#5227)
c5c9c5f Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5214)
ffb7aa6 Create comparativ.csl (#5215)
e07329a Update lancaster-university-harvard.csl (#5220)
c075d41 Update mimesis-edizioni.csl (#5219)
502970a Removed space in year only citation (#5218)
13e8c6b Update acta-scientiae-veterinariae.csl (#5209)
0699da6 Remake mammallia.csl for Oct/2020 guidelines. (#5207)
b2dd3fd Update journal-of-international-business-studies.csl (#5217)
dd52bfe Update quaternaire.csl (#5199)
ccb1b0d rebuild webpage and article-journal citations in journal-of-forensic-sciences.csl (#5203)
f02f4fb Create pedosphere.csl (#5196)
70dd87a Create open-gender-journal.csl (#5198)
d272998 Create the-quarterly-journal-of-economics.csl (#5197)
d27cab3 fix locale issues, add cite-locator (#5206)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 30fb68e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: linux status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
Archived in project
Development

No branches or pull requests

10 participants