Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword groups with keywords that consist only of spaces are displayed in a strange way #5333

Closed
sauliusg opened this issue Sep 20, 2019 · 2 comments · Fixed by #5347
Closed
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups

Comments

@sauliusg
Copy link
Contributor

sauliusg commented Sep 20, 2019

JabRef version 5.0-dev (commit db96f88 master) on Ubuntu-16.04 x86_64

[x ] I have tested the latest development version from * master db96f88 Fix problem with search and switching between libraries (#5326) from https://github.com/JabRef/jabref.git and the problem persists

When a bibtex database contains an entry with a keyword with only spaces in its value:

@Article{id3,
authors = {B. Kolker},
title = {Lernolibro de lingvo Esperanto},
keywords = {human > languages, , interlinguistics},
}

JabRef displays a strangely shifted empty keyword group that contains all entries:
Screenshot from 2019-09-20 14-39-51

Steps to reproduce the behavior:

  1. Load the file test-empty-keword-group-BROKEN.bib or test-empty-keword-group-BROKEN2.bib (from
    test-empty-keword-group.zip) into JabRef:
build/image/bin/JabRefMain test-empty-keword-group-BROKEN.bib &

The correctly formatted file test-empty-keword-group-OK.bib behaves as expected.

The partially broken file, test-empty-keword-group-FAIR.bib, that contains an empty "keyword":

@Article{id3,
authors = {B. Kolker},
title = {Lernolibro de lingvo Esperanto},
keywords = {human > languages,, interlinguistics},
}

(note missing spaces between the two consecutive commas) is also displayed as expected.

@tobiasdiez tobiasdiez added good first issue An issue intended for project-newcomers. Varies in difficulty. groups labels Sep 21, 2019
@AEgit
Copy link

AEgit commented Sep 21, 2019

JabRef 5.0-dev
Linux 5.0.0-29-generic amd64
Java 11.0.4

Can confirm this issue.

tobiasdiez added a commit that referenced this issue Sep 24, 2019
Fixes #5333 by filtering out empty keywords.
@AEgit
Copy link

AEgit commented Oct 3, 2019

JabRef 5.0.0-dev--2019-10-03----16eca244
Windows 10 10.0 amd64
Java 11.0.4

Can confirm this issue has been fixed in the current development version.

koppor pushed a commit that referenced this issue Mar 29, 2021
e1acabe Upload Styles (#5351)
d9cbf08 Update and rename journal-of-eta-maritime-science.csl to dependent/journal-of-eta-maritime-science.csl (#5353)
988ecca Update clinical-and-translational-immunology.csl (#5348)
1691078 Update molecular-plant-pathology.csl (#5349)
932a5bf Create neurospine.csl (#5334)
d663ffc Update sylwan.csl (#5341)
b7be05d Update pakistan-journal-of-agricultural-sciences.csl (#5343)
d742832 Please rename to Tijdschrift-voor-geneeskunde-en-gezondheidszorg (#5344)
6c6be4d Update et-al settings for journal-of-the-american-society-of-nephrology.csl (#5333)
0263204 Correct citation format of numeric AOSIS styles (#5335)
e4cd348 Create the-horticulture-journal.csl (#5327)
5804a6f Add AOSIS dependents (#5332)
2b4510b Create natura-croatia.csl (#5328)
03c6789 Create groundwater.csl (#5329)
e08fa09 Create hystrix-the-italian-journal-of-mammalogy.csl (#5330)
1d730aa update page-range-format for Anglia (#5331)
9bb8724 Sort American Physiological Society citation style according to updated author instructions (#5305)
a8b53ca Create african-online-scientific-information-systems-vancouver.csl (#5326)
c7d8f90 Update yozgat-bozok-universitesi-fen-bilimleri-enstitusu.csl (#5319)
87dc0eb Update and rename tijdschrift-voor-geneeskunde.csl to tijdschrift-voo… (#5325)
89e07b0 Create university-of-gothenburg-apa7-swedish-legislations (#5316)
4582cb6 Create chinese-law-journals.csl (#5314)
6412083 Create stellenbosch-law-review.csl (#5322)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: e1acabe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants