Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbhash sqldiff sqlite-analyzer sqlite 3.40.1 #119267

Closed
wants to merge 4 commits into from
Closed

dbhash sqldiff sqlite-analyzer sqlite 3.40.1 #119267

wants to merge 4 commits into from

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@p-linnane p-linnane added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing labels Dec 28, 2022
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 28, 2022
@cho-m cho-m added build failure CI fails while building the software linux Linux is specifically affected labels Dec 28, 2022
@chenrui333 chenrui333 removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 28, 2022
@chenrui333
Copy link
Member

for sqlite on linux build

  tclsh /tmp/sqlite-20221228-31551-1alhvzj/sqlite-src-3400100/tool/mkshellc.tcl >shell.c
  /bin/sh: 1: tclsh: not found

rpm and tracker test failures for osx build

brew test --retry --verbose rpm
brew test --retry --verbose tracker

@chenrui333
Copy link
Member

I can reproduce rpm in the master branch, but tracker works for me fine in the master branch build.

Formula/sqlite.rb Outdated Show resolved Hide resolved
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 30, 2022
@fxcoudert
Copy link
Member

rpm test failure on all targets. Either rpm need a revision bump, or the test needs to be fixed.

@fxcoudert fxcoudert removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 30, 2022
@SMillerDev
Copy link
Member

The test needs to be fixed, that happens outside of this PR too. I'm giving it a try now.

@fxcoudert fxcoudert removed the build failure CI fails while building the software label Dec 30, 2022
@SMillerDev
Copy link
Member

#119398 has the fixes, but doesn't pass brew style

@p-linnane
Copy link
Member Author

Rebased with @SMillerDev's rpm fixes.

@p-linnane p-linnane added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 30, 2022
@iMichka
Copy link
Member

iMichka commented Dec 30, 2022

Linux failure is unrelated (GitHub rate limit was hit during a recursive dependency test).

@BrewTestBot
Copy link
Member

:shipit: @p-linnane has triggered a merge.

@p-linnane p-linnane removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 30, 2022
@p-linnane p-linnane deleted the sqlite-3.40.1 branch December 30, 2022 23:12
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. linux Linux is specifically affected long build Set a long timeout for formula testing outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants