Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm 4.18 and test fixes #119398

Closed
wants to merge 1 commit into from
Closed

rpm 4.18 and test fixes #119398

wants to merge 1 commit into from

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the lua Lua use is a significant feature of the PR or issue label Dec 30, 2022
@SMillerDev
Copy link
Member Author

@Homebrew/brew this is going to fail the style check on the usage of RPM macros. Any suggestions how to avoid that? %<foo>s doesn't work so well in RPMs

@SMillerDev SMillerDev mentioned this pull request Dec 30, 2022
Closed
6 tasks
SMillerDev
SMillerDev commented Dec 30, 2022
View reviewed changes
Formula/rpm.rb Outdated Show resolved Hide resolved
SMillerDev
SMillerDev commented Dec 30, 2022
View reviewed changes
Formula/rpm.rb Outdated Show resolved Hide resolved
SMillerDev
SMillerDev commented Dec 30, 2022
View reviewed changes
Formula/rpm.rb Outdated Show resolved Hide resolved
SMillerDev
SMillerDev commented Dec 30, 2022
View reviewed changes
Formula/rpm.rb Outdated Show resolved Hide resolved
SMillerDev
SMillerDev commented Dec 30, 2022
View reviewed changes
Formula/rpm.rb Outdated Show resolved Hide resolved
@SMillerDev
Copy link
Member Author

It works on my machine 😅

  checking for mkfifoat... no
  configure: error: function required by rpm

@cho-m
Copy link
Member

cho-m commented Dec 30, 2022

rpm-software-management/rpm#2222

Sounds like mkfifoat was added in Ventura.

SMillerDev
SMillerDev commented Dec 30, 2022
View reviewed changes
Formula/rpm.rb Outdated Show resolved Hide resolved
@SMillerDev
Copy link
Member Author

Should probably try the suggestion from rpm-software-management/rpm#2332 (comment) here too

@p-linnane
Copy link
Member

Should we apply the flat namespace patch just on macOS?

@SMillerDev
rpm 4.18 and test fixes
972de0d 
rpm: fix whitespace

rpm: attempt to work around style issues

rpm: depend on macOS ventura

rpm: drop revision

rpm: add back patch and attempt to fix la removal
@BrewTestBot
Copy link
Member

:shipit: @p-linnane has triggered a merge.

@fxcoudert fxcoudert mentioned this pull request Dec 31, 2022
Closed
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
lua Lua use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SMillerDev @cho-m @p-linnane @BrewTestBot