Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbhash, sqldiff, sqlite-analyzer, sqlite 3.40.0 #115951

Closed
wants to merge 5 commits into from
Closed

dbhash, sqldiff, sqlite-analyzer, sqlite 3.40.0 #115951

wants to merge 5 commits into from

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@p-linnane p-linnane added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Nov 16, 2022
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 16, 2022
@branchvincent branchvincent removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 17, 2022
@chenrui333
Copy link
Member

tracker formula test failure on all osx

sqlite build issue on linux

  ==> make install
  tclsh /tmp/sqlite-20221116-4041-g4v3jn/sqlite-src-3400000/tool/mkshellc.tcl >shell.c
  /bin/sh: 1: tclsh: not found
  make: *** [Makefile:1128: shell.c] Error 127

@chenrui333 chenrui333 added the linux Linux is specifically affected label Nov 17, 2022
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 19, 2022
@chenrui333
Copy link
Member

only tracker formula failed on the regression tests.

@chenrui333 chenrui333 removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 20, 2022
@chenrui333
Copy link
Member

chenrui333 commented Nov 20, 2022

For tracker regression test failure, https://gitlab.gnome.org/GNOME/tracker/-/issues/387

@chenrui333
Copy link
Member

Log a separate new ticket for the issue, https://gitlab.gnome.org/GNOME/tracker/-/issues/388

@chenrui333
Copy link
Member

While this is being investigated in the upstream, I think we can merge the PR?

@p-linnane
Copy link
Member Author

@chenrui333 Works for me. Based off the response on the issue you opened, they are pointing to SQLite instead.

@chenrui333
Copy link
Member

I am gonna merge this for now, and handle tracker formulae separately.

@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@p-linnane p-linnane deleted the sqlite-3.40.0 branch November 23, 2022 22:41
@Bo98
Copy link
Member

Bo98 commented Nov 24, 2022

Error: 4 failed steps!
brew deps --tree --annotate --include-build --include-test sqlite
brew deps --tree --annotate --include-build --include-test dbhash
brew deps --tree --annotate --include-build --include-test sqldiff
brew deps --tree --annotate --include-build --include-test sqlite-analyzer

This was a genuine problem and should not have been ignored as it broke Homebrew on older Linux.

(In terms of Tracker: I'm a little concerned we've merged something with a potential regressions given Tracker team have told us it's a SQLite problem, but I've not looked into it so I'm not too conerned about that part.)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2022
@chenrui333
Copy link
Member

chenrui333 commented Dec 28, 2022

tclsh issue is back again on 3.40.1 linux build

  tclsh /tmp/sqlite-20221228-31551-1alhvzj/sqlite-src-3400100/tool/mkshellc.tcl >shell.c
  /bin/sh: 1: tclsh: not found

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. linux Linux is specifically affected long build Set a long timeout for formula testing outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants