-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show cursor pointer for option row where no press function is given #20553
Conversation
@arosiclair @s77rt One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/Videos |
|
fix: show cursor pointer for option row where no press function is given (cherry picked from commit 33fda84)
…-20553 🍒 Cherry pick PR #20553 to staging 🍒
🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 1.3.26-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀
|
Details
This PR resolves a deploy blocker where a disabled icon was being shown for option rows in the split participant page as well workspace members page.
Fixed Issues
$ #20495
PROPOSAL: #20495 (comment)
Tests
Go the app and open a workspace having more than 2 members.
Go to the
members
page of the workspace and verify that the members are selectable and the cursor islink
on each option row.Click
+
icon in the LHN and selectSplit bill
.Enter an amount, select some users and press next.
Verify that on the
MoneyRequestConfirmation
page, the cursor ispointer
when hovered over any row.Offline tests
N/A
QA Steps
Go the app and open a workspace having more than 2 members.
Go to the
members
page of the workspace and verify that the members are selectable and the cursor islink
on each option row.Click
+
icon in the LHN and selectSplit bill
.Enter an amount, select some users and press next.
Verify that on the
MoneyRequestConfirmation
page, the cursor ispointer
when hovered over any row.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
screen-recording-2023-06-10-at-12202-am_PIcTYIex.mp4
Mobile Web - Chrome
screen-recording-2023-06-10-at-13752-am_Vrnu2g3F.mp4
Mobile Web - Safari
screen-recording-2023-06-10-at-13904-am_ZPzABWqs.mp4
Desktop
screen-recording-2023-06-10-at-13500-am_wp7G3u4u.mp4
iOS
screen-recording-2023-06-10-at-14354-am_lYVcHTli.mp4
Android
screen-recording-2023-06-10-at-14445-am_WdvwNQB4.mp4