Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-06-12 #20640

Closed
71 tasks done
OSBotify opened this issue Jun 12, 2023 · 18 comments
Closed
71 tasks done

Deploy Checklist: New Expensify 2023-06-12 #20640

OSBotify opened this issue Jun 12, 2023 · 18 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 12, 2023

Release Version: 1.3.27-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 13, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.27-2 🚀

@isagoico
Copy link

PR #20217 is failing because of issue #12913

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.27-5 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.27-5 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.27-6 🚀

@thienlnam
Copy link
Contributor

Checking off #20682

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.27-6 has been deployed to staging 🎉

@isagoico
Copy link

PR #20409 is failing on mWeb because of this issue #20710

@isagoico
Copy link

Checking off #20276 as #20716 was defined as not a blocker

@mvtglobally
Copy link

mvtglobally commented Jun 14, 2023

Regression is near completed. We are down to 3%

PR #19545 pending validation on all platforms
PR #20217 is failing with old KI #12913. Repro in prod, so probably not a blocker
Are we ok to check it off? #20250 (comment) and PR #20290 (comment)?
PR #20344 pending validation on all platforms
PR #20406 pending validation on all platforms
PR #20407 is failing #20722. Repro in prod
PR #20409 #20409 (comment)
PR #20654 is failing. Adding issue in a bit

@mvtglobally
Copy link

mvtglobally commented Jun 14, 2023

@AndrewGable Regression is completed

Pending Blockers:
#20672
#20722
#20741

Latest status
PR #19545 failing #20749. repro in Prod checking off
PR #20217 is failing with old KI #12913. Repro in prod, so probably not a blocker
Are we ok to check it off? #20250 (comment) and PR #20290 (comment)?
PR #20344 Is failing #20755 repro in PROD. Checking off
PR #20406 is failing #20741
PR #20407 is failing #20722. Repro in prod
PR #20409 #20409 (comment)
PR #20654 is failing. Adding issue in a bit

@AndrewGable
Copy link
Contributor

PR #20217 is failing with old KI #12913. Repro in prod, so probably not a blocker

Agree 👍

Are we ok to check it off? #20250 (comment) and PR #20290 (comment)?

Yes, we are OK to check off

@AndrewGable
Copy link
Contributor

AndrewGable commented Jun 14, 2023

#20406 - Seems OK to check off per: #20741 (comment)

@AndrewGable
Copy link
Contributor

Let me know when you have issue for #20654, is it reproducible on production?

@mvtglobally
Copy link

@AndrewGable We did not log the issue a team was trying to get the final result. I posted Additional info here.
#20654 (comment)

@pecanoro
Copy link
Contributor

Checking off #20672 since it was tested after deploying a fix and now it's working.

@AndrewGable
Copy link
Contributor

Checked off #20654 per #20654 (comment)

@AndrewGable
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants