Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat-After changing time zone, the user does not receive and cann't send messages #20700

Closed
5 of 6 tasks
lanitochka17 opened this issue Jun 13, 2023 · 4 comments
Closed
5 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 13, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Precondition: mWeb/Chrome - change time zone
second device -Web

  1. Open http://staging.new.expensify.com/
  2. Log in
  3. Enter the chat with somebody on second device(for me -Web)
  4. Send message
  5. Go to settings>Profile>Timezone
  6. Change time zone (not automatically)
  7. Send new messages
  8. Check second device - No messages received on second device

Expected Result:

The user can send and receive messages

Actual Result:

The user sees that he is typing messages but does not receive it, and you need refresh the page to receive messages again.The sent message also does not reach the second user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.27.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.706.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jun 13, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@amyevans
Copy link
Contributor

Reproduced on staging:

20700-repro.mov

Seeing this in the console:
Screenshot 2023-06-13 at 2 25 37 PM

@amyevans
Copy link
Contributor

Logs for that request show:

Push_API - Flushing all pusher messages asynchronously and waiting for them to complete ~~ count: '6308'

So we are trying to send pusher events to a lot of accounts (my expensifail account is on the High Traffic policy).

The last line shows we're hitting the nginx timeout (I think?):

{
  "_index": "logs_expensify-022791",
  "_type": "log",
  "_id": "GtL7tYgBRPBZDqJjqP2d",
  "_score": null,
  "_ignored": [
    "nginx_timestamp"
  ],
  "_source": {
    "type": "web",
    "timestamp": "2023-06-13T18:19:07.250792+00:00",
    "host": "staging-www1.rno",
    "process": "nginx",
    "upstream_header_time": "-",
    "upstream_connect_time": "0.000",
    "upstream_response_time": "32.076",
    "request_time": "32.092",
    "upstream_status": "502",
    "http_user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36",
    "body_bytes_sent": "292517",
    "http_status": "502",
    "server_protocol": "HTTP/1.1",
    "request": "/api?",
    "request_method": "GET",
    "nginx_timestamp": "13/Jun/2023:18:19:07 +0000",
    "remote_user": "-",
    "http_host": "staging.expensify.com",
    "remote_addr": "71.192.155.173",
    "request_id": "7d6c564168b33b69-SJC",
    "blob": "",
    "tsb": "2023-06-13T17:19:07.250Z",
    "tsa": "2023-06-13T19:19:07.250Z"
  },
  "sort": [
    1686680347250
  ],
  "type": "web",
  "timestamp": "2023-06-13T18:19:07.250792+00:00",
  "host": "staging-www1.rno",
  "process": "nginx",
  "upstream_header_time": "-",
  "upstream_connect_time": "0.000",
  "upstream_response_time": "32.076",
  "request_time": "32.092",
  "upstream_status": "502",
  "http_user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36",
  "body_bytes_sent": "292517",
  "http_status": "502",
  "server_protocol": "HTTP/1.1",
  "request": "/api?",
  "request_method": "GET",
  "nginx_timestamp": "13/Jun/2023:18:19:07 +0000",
  "remote_user": "-",
  "http_host": "staging.expensify.com",
  "remote_addr": "71.192.155.173",
  "request_id": "7d6c564168b33b69-SJC",
  "blob": "",
  "tsb": "2023-06-13T17:19:07.250Z",
  "tsa": "2023-06-13T19:19:07.250Z",
  "shortTimestamp": "2023-06-13 18:19:07 250",
  "request_id_html": "7d6c564168b33b69-SJC",
  "timestamp_html": "2023-06-13 18:19:07 250",
  "email_html": ""
}

I believe we're temporarily sending 2x the number of pusher events while the Secure Logins refactor project is taking place, so once we stop doing that this should clear up (and it's not reproducible on an account that's part of a smaller policy).

But in any event, this isn't related to a change in App code so isn't a Deploy Blocker.

@amyevans amyevans removed the DeployBlockerCash This issue or pull request should block deployment label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants