[$1000] [HOLD for payment 2023-06-21] [HOLD for payment 2023-06-19] WS - Members list - Tooltip “Blocked” appears when user moves cursor over usernames / avatars

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Start Expensify and login with any account
2. Go to any workspace or create the new one
3. Go to Workspace > Members and invite some users to workspace
4. Move cursor over avatars and user names

Expected Result:

The cursor is hand-shaped and gives checkbox marks anywhere

Actual Result:

The cursor has tooltip 'block/unavailable' and gives checkbox marks only in checkbox area

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.26-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6086010_Desktop-Tooltip-Blocked-Usernames.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e6ff8ea4d60e1484
• Upwork Job ID: 1671674682457559040
• Last Price Increase: 2023-06-22

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dostongulmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS - Members list - Tooltip “Blocked” appears when user moves cursor over usernames / avatars

What is the root cause of that problem?

The option row is disabled and onSelectRow and isSelected props values are not given to the option row

What changes do you think we should make in order to solve the problem?

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 347 to 350 in 82ce35f

	<OptionRow
	isDisabled
	boldStyle
	option={{

1. Remove isDisabled
2. add here isSelected={isChecked} and onSelectRow={() => this.toggleUser(item.login, item.pendingAction)} as props to the OptionRow component

What alternative solutions did you explore? (Optional)

[trjExpensify]

@marcochavezf @allroundexperts @Skalakid - are you guys looking into this as a regression from #19664?

Related convo.

[allroundexperts]

@marcochavezf @allroundexperts @Skalakid - are you guys looking into this as a regression from #19664?

Related convo.

Checking this now @trjExpensify.

[allroundexperts]

@trjExpensify This is not a regression from #19664. This happened after this PR.

[trjExpensify]

Yup, thanks for isolating it!

[arosiclair]

Took some time looking into this. The OptionRows for the WorkspaceMembersPage and the MoneyRequestConfirmationList are disabled since they aren't actionable which causes the disabled cursor to show on hover. Removing the disabled property defaults the cursor to a pointer option which isn't great either since those options aren't actionable:

Screen.Recording.2023-06-09.at.2.14.26.PM.mov

At this point I'm out of ideas, but @allroundexperts said he'll look into this soon

[allroundexperts]

Yup. On it!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: show cursor pointer for option row where no press function is given #20553

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: show cursor pointer for option row where no press function is given #20553

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 @allroundexperts can you get to the checklist please?

Also, I'm a bit hazy on the history here. Was this confirmed not a regression in the end, so it's just standard payment for the fix? ($1000).

[allroundexperts]

Also, I'm a bit hazy on the history here. Was this confirmed not a regression in the end, so it's just standard payment for the fix? ($1000).

@tjferriss This was a regression from a PR which was not done by me. This happened after #19612.

The PR I created got merged the same day so I think it should be eligible for the bonus as well.

[allroundexperts]

Checklist:

1. PR which introduced this was 17013 - migrate OptionRow to PressableWithFeedback #19612.
2. PR was commented on here.
3. I don't think that we could have done anything to avoid this other than more careful testing. As such, I feel like that Slack discussion is not needed.
4. It would be good to have the regression test in place for this. The steps given in the description seem sufficient.

[trjExpensify]

Cool, we already have it in step 7 here I think.

1. Final Review page
2. Verify that the next page you see is the final confirmation screen
3. Verify that the total amount entered on the BNP is left-aligned in the header next to the back caret with the correct currency e.g < Split $100
4. Verify that your name appears under the Who paid? header
5. Verify that the attendees you added appear under the Who was there? header
6. Verify that you cannot select/deselect the attendees
7. Web/Desktop - Verify that the cursor does not turn into a pointer when hovering over the attendees under "Who was there?"
8. Verify that the amounts next to each attendee (including yourself as the payer) reflects an equal split of the total amount entered on the BNP e.g $25
9. Add a comment, then select the Split Bill confirmation button
10. Verify that the modal closes and that you land in the Group DM with exactly the same set of users you just split the bill with

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e6ff8ea4d60e1484

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

[trjExpensify]

Sent you an offer for $1,500 here.

[trjExpensify]

Settled!