Deploy Checklist: New Expensify 2022-01-25

[OSBotify]

Release Version: 1.1.33-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• improve setPassword UX #6587

  • QA
  • Accessibility

• Add ChooseTransferAccountPage and allow selecting accounts for wallet transfer #7200

  • QA
  • Accessibility

• Fix : android crash when attaching a large size image  #7209

  • QA
  • Accessibility

• Rename Policy Rooms #7217

  • QA
  • Accessibility

• Fix report icon logic for newly created policy rooms #7252

  • QA
  • Accessibility

• Show default workspace rooms #7301

  • QA
  • Accessibility

• add new error message #7319

  • QA
  • Accessibility

• Upgraded react-native-modal to v13.0.0 #7333

  • QA
  • Accessibility

• Bump Onyx version #7343

  • QA
  • Accessibility

• [No QA] Dont require accessibility checkboxes to ship a deploy checklist #7348

  • QA
  • Accessibility

• Fix : Unable to type next paragraph in message #7355

  • QA
  • Accessibility

• Separate report name and icon configuration from personal details #7367

  • QA
  • Accessibility

• Correct close account confirmation modal logic. #7368

  • QA
  • Accessibility

• Update to latest react-native-onyx version #7370

  • QA
  • Accessibility

• [No QA] Small design tweaks #7373

  • QA
  • Accessibility

• [NO-QA] Add beta flag section to the contributing readme #7389

  • QA
  • Accessibility

• Remove credentials and session from Onyx on sign out #7397

  • QA
  • Accessibility

• Remove import to fix lint error #7406

  • QA
  • Accessibility

• [CP Stg] Resolve getImageSize promise with an object instead of multiple values #7414

  • QA
  • Accessibility

• Revert "Separate report name and icon configuration from personal details" #7426

  • QA
  • Accessibility

Internal QA:

• Don't allow users to chat with Concierge when blocked #7340 - @puneetlath

Deploy Blockers:

• Web - Lost Chat with a new user page after switch the tab #7412
• Android / iOS - Concierge is displayed with email address in LHN  #7417
• Android - Not able to connect to a bank account tapping " bank account" under transfer money #7418
• [$4000] Android - Infinite loading spinner appears when sign in to the app leaving idle for 10 min after sign out #7424
• Workspace - The #announce and #admin rooms appears in LHN by default when a new workspace is created #7429

cc @Expensify/applauseleads

[mvtglobally]

Starting QA

[mvtglobally]

@AndrewGable Can you pls confirm 1.1.32-1 is the build we should QA?

[AndrewGable]

Yes, correct

[puneetlath]

Confirmed #7340 is working.

[roryabraham]

I'm unable to reproduce #7412 – can anyone else help verify that it is reproducible? If nobody else can reproduce it, I'll just close it. If it's inconsistent, I might demote it from being a deploy blocker to just a regular bug.

[mvtglobally]

Regression is almost complete. I will run through it again in the morning to make sure we didn't miss anything as this list is huge :(

Blockers
#7209 failing due to #7407
#7301 is failing due to #7412
#7367 is failing due to #7417
#7418
#7424
#7429

Issues logged so far
#7425 found when running #6587 - repro in prod
#7398 found when running #7200 - can you confirm we can check it off as definitely not a blocker?
#7400 found when running #7217
#7399 found when running #7367
#7361 found when running #7370
#7413
#7420
#7422
#7431
#7432

Retesting
#7397 due to #7424
#7414
#7412

[mvtglobally]

@AndrewGable we are still not seeing 1.1.33-3 on Android to validate some fixes. Can you check if its still in review and can be pushed in some way

[roryabraham]

@mvtglobally 1.1.33-3 was reject by Google. We've submitted an appeal, but are waiting to hear back. cc @Julesssss

[Julesssss]

Hi @mvtglobally, Google has accepted our rejection appeal and I have just resubmitted the app for review 🤞

[mvtglobally]

Great @Julesssss we will continue retests then

[mvtglobally]

Checking off
#7209 -#7414 issue is fixed
#7301 - issue is not consistently repro, blocker removed
#7367 - it was reverted
#7217 - #7400 is not a blocker
#7370 - #7361 is closed
#7417 is pass
#7200 - not a blocker #7398

[mvtglobally]

@AndrewGable @Julesssss Let us know if we can checkoff to close this checklist
#7319 (comment) Checking off
#7424 & #7412 as they are not consistently repro by Expensify team
Last blocker has no comment #7418

[sketchydroide]

it seems #7412 is no longer a blocker
#7424 is being followed, a solution has not been found yet
#7418 needs to be tested again on the latest version, 1.1.33-3. it was found on 1.1.33-2 and I could not replicate it in the newer version.

[mvtglobally]

Retesting #7418

[mvtglobally]

Checking off #7418 - is no longer repro

[mvtglobally]

@AndrewGable @roryabraham #7424 is the only blocker preventing deploy it seems. Last deploy was a week ago, it would be nice if we can get a new one today to QA.

[roryabraham]

#7424 has been demoted from deploy blocker to bug, checking it off for now. Let's retest it weekly with other KI's please.

[roryabraham]

#7412 was also demoted as well.

[roryabraham]